add image_height and image_width in PanoramaInfo #2753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I checked this PR with #2754 , and it works. Screencast.2022-12-07.23.11.53.mp4 |
sometimes network is too slow
sktometometo
approved these changes
Dec 13, 2022
|
この変更見ていて気づいたんですが、PanoramaInfo に画像の情報入れてしまうと、画像だけresizeして使うという使い方はできなくなりますね. |
|
#2754 にあるresizeオプションは消した方がいいかと思います。 |
|
sample に使っている rosbag の変更も必要そうです |
|
rosbagはまだとっていません． |
|
とおもったけど，やっぱりpanorama info resizeのスクリプトを書くことにしました． |
k-okada
approved these changes
Jan 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR add
image_heightandimage_widthfield inPanoramaInfo.this infomation is used in
rect_array_in_panoram_to_bounding_box.py.PanoramaInfois lighter thanPanoramaImage, andrect_array_in_panoram_to_bounding_box.pyonly needs the shape information, thus I add this field.related: #2752
cc. @AyumuIwa