Fix audio to spectrogram plot and add test #2764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k-okada
reviewed
Feb 26, 2023
| import cv_bridge | ||
| from dynamic_reconfigure.server import Server | ||
| from jsk_topic_tools import ConnectionBasedTransport | ||
| import matplotlib | ||
| matplotlib.use('Agg') |
| oneshot=False, | ||
| ) | ||
| if (LooseVersion(pkg_resources.get_distribution('rospy').version) >= | ||
| LooseVersion('1.12.0')): |
There was a problem hiding this comment.
how about add checking use_sim_time?
There was a problem hiding this comment.
Thank you.
85af1af
I added code to check use_sim_time
iory
force-pushed
the
fix-audio-to-spectrogram-plot
branch
from
cd5df7b
to
02002ab
Compare
iory
force-pushed
the
fix-audio-to-spectrogram-plot
branch
from
02002ab
to
be635ab
Compare
pazeshun
approved these changes
Feb 27, 2023
There was a problem hiding this comment.
I confirmed this PR works with apt-version matplotlib (2.1.1).
I also confirmed this works with pip-version matplotlib (2.2.5) and prints warning messages as intended.
Just FYI:
The latter is slower than the former even though both of them use Agg, not default TkAgg.
So when the apt-version matplotlib is updated in the future, we will face slowing down.
But I think this is not a problem because slowing down is not so big.
See #2759 (comment) for more detail.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this?
This change is by defaulting to Agg as the backend for matplotlib.
See #2759