Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jsk_perception] Fix nodehandle in point_pose_extractor #2779

Merged
merged 4 commits into from May 25, 2023

Conversation

nakane11
Copy link
Member

@nakane11 nakane11 commented May 23, 2023

This PR fixes the problem reported in #2778 and depends on #2778.
pnh was mistakenly used instead of nh by #2722.

Now the result of rosnode info /kinect_head/rgb/point_pose_extractor is here:

Node [/kinect_head/rgb/point_pose_extractor]
Publications: 
 * /diagnostics [diagnostic_msgs/DiagnosticArray]
 * /kinect_head/rgb/ObjectDetection [posedetection_msgs/ObjectDetection]
 * /kinect_head/rgb/ObjectDetection_agg [posedetection_msgs/ObjectDetection]
 * /kinect_head/rgb/object_pose [geometry_msgs/PoseStamped]
 * /kinect_head/rgb/point_pose_extractor/debug_image [sensor_msgs/Image]
 * /kinect_head/rgb/point_pose_extractor/debug_image/compressed [sensor_msgs/CompressedImage]
 * /kinect_head/rgb/point_pose_extractor/debug_image/compressed/parameter_descriptions [dynamic_reconfigure/ConfigDescription]
 * /kinect_head/rgb/point_pose_extractor/debug_image/compressed/parameter_updates [dynamic_reconfigure/Config]
 * /kinect_head/rgb/point_pose_extractor/debug_image/compressedDepth [sensor_msgs/CompressedImage]
 * /kinect_head/rgb/point_pose_extractor/debug_image/compressedDepth/parameter_descriptions [dynamic_reconfigure/ConfigDescription]
 * /kinect_head/rgb/point_pose_extractor/debug_image/compressedDepth/parameter_updates [dynamic_reconfigure/Config]
 * /kinect_head/rgb/point_pose_extractor/debug_image/theora [theora_image_transport/Packet]
 * /kinect_head/rgb/point_pose_extractor/debug_image/theora/parameter_descriptions [dynamic_reconfigure/ConfigDescription]
 * /kinect_head/rgb/point_pose_extractor/debug_image/theora/parameter_updates [dynamic_reconfigure/Config]
 * /rosout [rosgraph_msgs/Log]
 * /tf [tf2_msgs/TFMessage]

Subscriptions: 
 * /ImageFeature0D [unknown type]

Services: 
 * /kinect_head/rgb/SetTemplate
 * /kinect_head/rgb/point_pose_extractor/debug_image/compressed/set_parameters
 * /kinect_head/rgb/point_pose_extractor/debug_image/compressedDepth/set_parameters
 * /kinect_head/rgb/point_pose_extractor/debug_image/theora/set_parameters
 * /kinect_head/rgb/point_pose_extractor/get_loggers
 * /kinect_head/rgb/point_pose_extractor/list
 * /kinect_head/rgb/point_pose_extractor/load_nodelet
 * /kinect_head/rgb/point_pose_extractor/set_logger_level
 * /kinect_head/rgb/point_pose_extractor/unload_nodelet

Copy link
Member

@tkmtnt7000 tkmtnt7000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for quick fixing!
Could you add a test code that uses group namespace such as #2778 ?

@nakane11
Copy link
Member Author

@tkmtnt7000 Thank you for your advice!
rostest succeeded.

[jsk_perception.rosunit-test_group_ns_point_pose_extractor/test_published][passed]

SUMMARY
 * RESULT: SUCCESS
 * TESTS: 1
 * ERRORS: 0
 * FAILURES: 0

@tkmtnt7000
Copy link
Member

Thank you. I have confirmed that this pr worked on local pc and pr2, and test passed.

@k-okada k-okada merged commit d9ba446 into jsk-ros-pkg:master May 25, 2023
11 checks passed
@nakane11 nakane11 deleted the fix-point-pose-extractor branch May 25, 2023 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants