Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roseus message generator make catkin_LIBRARIES empty on groovy #24

Closed
garaemon opened this issue Mar 28, 2014 · 4 comments
Closed

roseus message generator make catkin_LIBRARIES empty on groovy #24

garaemon opened this issue Mar 28, 2014 · 4 comments
Assignees

Comments

@garaemon
Copy link
Member

It's a critical bug. This bug only related with groovy/catkin.

as mentioned in here jsk-ros-pkg/jsk_common#331, all the package which will be compiled after roseus will have empty ${catkin_LIBRARIES}.

Actually, in configuration time, ${catkin_LIBRARIES} is set correctly but in compilation time, target_link_libraries tries to link with no-library.

@garaemon garaemon changed the title roseus message generator make catkin_LIBRARIES empty roseus message generator make catkin_LIBRARIES empty on groovy Mar 28, 2014
@garaemon
Copy link
Member Author

diff between groovy and hydro:

diff /opt/ros/groovy/share/catkin/cmake/catkinConfig.cmake /opt/ros/hydro/share/catkin/cmake/catkinConfig.cmake 
84c84,91
<     list_append_unique(catkin_LIBRARIES ${${component}_LIBRARIES})
---
> 
>     # merge build configuration keywords with library names to correctly deduplicate
>     catkin_pack_libraries_with_build_configuration(catkin_LIBRARIES ${catkin_LIBRARIES})
>     catkin_pack_libraries_with_build_configuration(_libraries ${${component}_LIBRARIES})
>     list_append_deduplicate(catkin_LIBRARIES ${_libraries})
>     # undo build configuration keyword merging after deduplication
>     catkin_unpack_libraries_with_build_configuration(catkin_LIBRARIES ${catkin_LIBRARIES})
> 

@garaemon
Copy link
Member Author

${catkin_LIBRARIES} will be empty after call generate_messages.
Consequently if we call find_package(catkin REQUIRED COMPONENTS ...) after generate_messages(), everything goes well.

@garaemon
Copy link
Member Author

If we move the position of calling generate_messages, we can avoid this problem. this is just a hack.

garaemon/jsk_common@849fb5f

@k-okada
Copy link
Member

k-okada commented Apr 5, 2014

#46 should fix this

@k-okada k-okada closed this as completed Apr 5, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants