Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unmatched parenthesis #607

Merged
merged 1 commit into from
Mar 29, 2019

Conversation

Affonso-Gui
Copy link
Member

Actually noticed some unmatching parenthesis on roseus.l, so am reporting it.

@Affonso-Gui
Copy link
Member Author

@mmurooka Review would be appreciated

@mmurooka
Copy link
Member

Looks good to me.
Why was the before-fix program loaded correctly even though parenthesis was unmatch.

@Affonso-Gui
Copy link
Member Author

Euslisp allows to have extra parenthesis in the end or at some cases to omit closing parenthesis.

test.l

(defun foo () (list 1 2 3))))

(defun bar () (list 1 2 3
irteusgl> (load "test.l")
t
irteusgl> (foo)
(1 2 3)
irteusgl> (bar)
(1 2 3)

Another good question is why is this behavior supported.

@k-okada k-okada merged commit f577ade into jsk-ros-pkg:master Mar 29, 2019
@Affonso-Gui Affonso-Gui deleted the fix-unmatched-parens branch March 29, 2019 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants