Add get_roslint_results_xml.py to collect roslint error result

Modified:
	 travis.sh
Added:
	 get_roslint_result_xml.py

get_roslint_result_xml.py

@@ -0,0 +1,111 @@
+#!/usr/bin/env python
+# -*- coding: utf-8 -*-
+
+import argparse
+import re
+import os
+import shlex
+import subprocess
+from subprocess import Popen, PIPE
+
+
+def get_commits_from_origin():
+    cmd = 'git log --format="%h" origin/master..'
+    commits = subprocess.check_output(shlex.split(cmd)).splitlines()
+    return commits
+
+
+def get_changed_files_from_origin():
+    cmd = r"git log --name-status origin/master.. | grep -E '^[A-Z]\b'"
+    files = subprocess.check_output(cmd, shell=True).splitlines()
+    files = [f.split('\t')[-1] for f in files]
+    return files
+
+
+def get_changed_lines_of_commit(commit, files):
+    cmd = 'git blame {}'
+    for f in files:
+        blame = subprocess.check_output(shlex.split(cmd.format(f)))
+        for i, line in enumerate(blame.splitlines()):
+            line_num = i + 1
+            if re.search('^' + commit, line):
+                return commit, f, line_num
+
+
+def get_buildspace():
+    cmd = "catkin --no-color config | grep '^Build Space' | awk '{print $4}'"
+    buildspace = subprocess.check_output(cmd, shell=True).strip()
+    return buildspace
+
+
+def get_roslint_results(pkg):
+    cwd = os.path.join(get_buildspace(), pkg)
+    cmd = 'make roslint'
+    p = Popen(shlex.split(cmd), cwd=cwd,
+              stdin=None, stdout=None, stderr=PIPE, close_fds=True)
+    results = []
+    for line in p.stderr.readlines():
+        m = re.match('(.*?):([0-9].*?):  (.*?)$', line)
+        if m is None:
+            continue
+        fname, line_num, message = m.groups()
+        results.append((fname, int(line_num), message))
+    return results
+
+
+def compose_report_xml(reports, repo_slug, pr_num):
+    owner, repo = repo_slug.split('/')
+    xml = '<roslint>'
+    xml += '''\
+<remote>
+  <github owner="{owner}" repository="{repo}" pullrequest="{pr_num}" />
+</remote>
+<result>
+'''.format(owner=owner, repo=repo, pr_num=pr_num)
+    results = []
+    for rep in reports:
+        fname, commit, line_num, message = rep
+        result = '''\
+<file path="{path}" commit="{commit}">
+  <error line="{line_num}">{msg}</error>
+</file>
+'''.format(path=fname, commit=commit, line_num=line_num, msg=message)
+        results.append(result)
+    xml += '\n'.join(results)
+    xml += '</result>\n</roslint>\n'
+    return xml
+
+
+def get_roslint_result_xml(packages, repo_slug, pr_num, output):
+    commits = get_commits_from_origin()
+    files = get_changed_files_from_origin()
+    diff_lines = []
+    for commit in commits:
+        diff_lines.append(get_changed_lines_of_commit(commit, files))
+
+    lint_results = []
+    for pkg in packages:
+        lint_results.extend(get_roslint_results(pkg))
+    lint_reports = []
+    for commit, fname0, line_num0 in diff_lines:
+        for fname1, line_num1, message in lint_results:
+            if os.path.abspath(fname0) == fname1 and line_num0 == line_num1:
+                lint_reports.append((fname0, commit, line_num0, message))
+    xml = compose_report_xml(lint_reports, repo_slug, pr_num)
+    with open(output, 'w') as f:
+        f.write(xml)
+
+
+def main():
+    parser = argparse.ArgumentParser()
+    parser.add_argument('packages', nargs='*')
+    parser.add_argument('--repo-slug', required=True)
+    parser.add_argument('--pr-number', required=True)
+    parser.add_argument('--out-file', required=True)
+    args = parser.parse_args()
+    get_roslint_result_xml(
+        args.packages, args.repo_slug, args.pr_number, output=args.out_file)
+
+
+if __name__ == '__main__':
+    main()

travis.sh

@@ -196,6 +196,11 @@ if [ "$ROS_DISTRO" == "hydro" ]; then
     (cd /opt/ros/$ROS_DISTRO/share; wget --no-check-certificate https://patch-diff.githubusercontent.com/raw/ros/ros_comm/pull/611.diff -O - | sed s@.cmake.em@.cmake@ | sed 's@/${PROJECT_NAME}@@' | sed 's@ DEPENDENCIES ${_rostest_DEPENDENCIES})@)@' | sudo patch -f -p2 || echo "ok")
 fi
 
+# run roslint and report on github's pr page
+if [ "${TRAVIS_PULL_REQUEST}" != "false" ]; then
+  (cd $CI_SOURCE_PATH && .travis/get_roslint_result_xml.py $BUILD_PKGS --repo-slug $TRAVIS_REPO_SLUG --pr-number ${TRAVIS_PULL_REQUEST} --out-file /tmp/roslint_result.xml)
+fi
+
 if [ "$BUILDER" == catkin ]; then
     source devel/setup.bash > /tmp/$$.x 2>&1; grep export\ [^_] /tmp/$$.x ; rospack profile # force to update ROS_PACKAGE_PATH for rostest
     catkin run_tests -iv --no-deps --limit-status-rate 0.001 $TEST_PKGS $CATKIN_PARALLEL_TEST_JOBS --make-args $ROS_PARALLEL_TEST_JOBS --