Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix moc generation errors with boost >= 1.57 (for OS X currently) #598

Merged
merged 2 commits into from Jun 2, 2016
Merged

Fix moc generation errors with boost >= 1.57 (for OS X currently) #598

merged 2 commits into from Jun 2, 2016

Conversation

wkentaro
Copy link
Member

@wkentaro wkentaro commented Jun 1, 2016 •
edited

tag: pkg/jsk_rviz_plugins, feature

Please refer to ros-visualization/rviz#826

@wkentaro
Copy link
Member Author

wkentaro commented Jun 1, 2016

With this PR jsk_rviz_plugins works on OS X.
screen shot 2016-06-01 at 20 47 49

@wkentaro
Copy link
Member Author

wkentaro commented Jun 2, 2016

Please merge this.

@k-okada
Copy link
Member

k-okada commented Jun 2, 2016

test is failing

@wkentaro
Copy link
Member Author

wkentaro commented Jun 2, 2016

test is failing

?

image

@k-okada k-okada merged commit a703b88 into jsk-ros-pkg:master Jun 2, 2016
@k-okada
Copy link
Member

k-okada commented Jun 2, 2016

sorry, i missed that, btw why just add +#ifndef Q_MOC_RUN works?

@wkentaro wkentaro deleted the fix-boost-moc-err branch June 2, 2016 10:19
@wkentaro
Copy link
Member Author

wkentaro commented Jun 2, 2016

This is a bug in Qt4 MOC compilier: https://bugreports.qt.io/browse/QTBUG-22829
When Qt programs are being built, the moc target is also built.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wkentaro @k-okada