enable to modify caption contents for Plotter2D and PieChart #636

k-okada · 2016-09-12T06:42:51Z

Closes #634

you can try this with roslaunch jsk_rviz_plugins 2dplot_sample.launch

k-okada · 2016-09-12T08:08:32Z

Warnings   << jsk_interactive_marker:cmake /workspace/ros/ws_jsk_visualization/logs/jsk_interactive_marker/build.cmake.000.log
copy /workspace/ros/ws_jsk_visualization/src/jsk_visualization/jsk_interactive_markers/jsk_interactive_marker/launch/atlas_joint_marker.rviz.default to /workspace/ros/ws_jsk_visualization/src/jsk_visualization/jsk_interactive_markers/jsk_interactive_marker/launch/atlas_joint_marker.rviz
copy /workspace/ros/ws_jsk_visualization/src/jsk_visualization/jsk_interactive_markers/jsk_interactive_marker/launch/interactive_marker.rviz.default to /workspace/ros/ws_jsk_visualization/src/jsk_visualization/jsk_interactive_markers/jsk_interactive_marker/launch/interactive_marker.rviz
copy /workspace/ros/ws_jsk_visualization/src/jsk_visualization/jsk_interactive_markers/jsk_interactive_marker/config/robot_actions_sample.rviz.default to /workspace/ros/ws_jsk_visualization/src/jsk_visualization/jsk_interactive_markers/jsk_interactive_marker/config/robot_actions_sample.rviz
cd /workspace/ros/ws_jsk_visualization/build/jsk_interactive_marker; catkin build --get-env jsk_interactive_marker | catkin env -si  /usr/bin/cmake /workspace/ros/ws_jsk_visualization/src/jsk_visualization/jsk_interactive_markers/jsk_interactive_marker --no-warn-unused-cli -DCATKIN_DEVEL_PREFIX=/workspace/ros/ws_jsk_visualization/devel/.private/jsk_interactive_marker -DCMAKE_INSTALL_PREFIX=/workspace/ros/ws_jsk_visualization/install; cd -
...............................................................................
_______________________________________________________________________________
Errors     << jsk_interactive_marker:make /workspace/ros/ws_jsk_visualization/logs/jsk_interactive_marker/build.make.000.log
CMakeFiles/footstep_marker.dir/src/footstep_marker.cpp.o: file not recognized: File truncated
collect2: error: ld returned 1 exit status
make[2]: *** [/workspace/ros/ws_jsk_visualization/devel/.private/jsk_interactive_marker/lib/jsk_interactive_marker/footstep_marker] Error 1
make[1]: *** [CMakeFiles/footstep_marker.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
make: *** [all] Error 2
cd /workspace/ros/ws_jsk_visualization/build/jsk_interactive_marker; catkin build --get-env jsk_interactive_marker | catkin env -si  /usr/bin/make --jobserver-fds=6,7 -j; cd -
...............................................................................
Failed     << jsk_interactive_marker:make           [ Exited with code 2 ]
Failed    <<< jsk_interactive_marker                [ 15.7 seconds ]
Abandoned <<< jsk_interactive                       [ Unrelated job failed ]
Abandoned <<< jsk_interactive_test

k-okada · 2016-09-12T10:27:38Z

not sure why, but did not compile on jade https://travis-ci.org/jsk-ros-pkg/jsk_visualization/jobs/159271307, switch to jenkins...

wkentaro · 2016-09-12T12:22:41Z

jsk_rviz_plugins/src/pie_chart_display.cpp

@@ -359,6 +363,11 @@ namespace jsk_rviz_plugins

  }

+  void PieChartDisplay::updateCaption()
+  {
+    caption_ = caption_property_->getStdString();


Why not below implementation for backward compatibility of current existing rviz config file, and convenience.

std::string caption = caption_property_->getStdString(); if (caption.empty()) { caption_ = std::string(getName()); // the name of display } else { caption_ = caption; }

i tried to use getName() but did not know where is this function and name_ defined.

btw, caption_property_->getStdString(); is initialized at https://github.com/jsk-ros-pkg/jsk_visualization/pull/636/files#diff-21915262cfae72cf9ac2af03ff4ea8e7R91, so if you worried about null caption name, then we can set at there.
If you think we do not have to define caption_, but can use name_, I do not have confident on modifying name_ because did not know how is this variable used

i tried to use getName() but did not know where is this function and name_ defined.

Maybe this? http://docs.ros.org/diamondback/api/rviz/html/classrviz_1_1Display.html#a7f3a75feb307f0cc307f7c78897d4237

btw, caption_property_->getStdString(); is initialized at https://github.com/jsk-ros-pkg/jsk_visualization/pull/636/files#diff-21915262cfae72cf9ac2af03ff4ea8e7R91, so if you worried about null caption name, then we can set at there.
If you think we do not have to define caption_, but can use name_, I do not have confident on modifying name_ because did not know how is this variable used

Probably name_ is the name of display (below) and should not be changed, so I think caption_ variable is necessary.

maybe we do not need this PR, see #638 and #634

Btw, please look at .rviz file in this commit. It uses old format and works ok, so we do not need #636 (comment) for backward compatibility

k-okada · 2016-09-12T16:45:30Z

finally, it passed the test, i have to rm -fr jenkins@jenkins:/export/data1/ccache, even ccache -C did not work.

jenkins@jenkins:/export/data1/ccache$ CCACHE_DIR=`pwd` ccache  -s

if no one knows how to deal with this situation, I think using ccache is dangerous, it took 8 hours for me......

wkentaro · 2016-09-12T18:56:42Z

if no one knows how to deal with this situation, I think using ccache is dangerous, it took 8 hours for me......

Really.. I don't know how to fix this, but why not automatically remove the cache at reboot of jenkins?
If it is easy, I prefer that solution because ccache is very useful to make the build faster in most case.

k-okada mentioned this pull request Sep 12, 2016

caption contents for Plotter2D and PieChart in jsk_rviz_plugins? #634

Closed

k-okada force-pushed the fix_634 branch 2 times, most recently from 0485821 to 2e3de5d Compare September 12, 2016 10:26

wkentaro reviewed Sep 12, 2016
View reviewed changes

k-okada mentioned this pull request Sep 12, 2016

disable parallel jobs #637

Closed

enable to modify caption contents for Plotter2D and PieChart

c2a7ae7

k-okada force-pushed the fix_634 branch from 2e3de5d to c2a7ae7 Compare September 12, 2016 16:01

k-okada closed this Sep 12, 2016

k-okada deleted the fix_634 branch September 12, 2016 17:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

enable to modify caption contents for Plotter2D and PieChart #636

enable to modify caption contents for Plotter2D and PieChart #636

k-okada commented Sep 12, 2016 •

edited

Loading

k-okada commented Sep 12, 2016

k-okada commented Sep 12, 2016

wkentaro Sep 12, 2016

k-okada Sep 12, 2016

k-okada Sep 12, 2016 •

edited

Loading

wkentaro Sep 12, 2016 •

edited

Loading

wkentaro Sep 12, 2016 •

edited

Loading

k-okada Sep 12, 2016

k-okada Sep 12, 2016

wkentaro Sep 12, 2016

k-okada commented Sep 12, 2016

wkentaro commented Sep 12, 2016

enable to modify caption contents for Plotter2D and PieChart #636

enable to modify caption contents for Plotter2D and PieChart #636

Conversation

k-okada commented Sep 12, 2016 • edited Loading

k-okada commented Sep 12, 2016

k-okada commented Sep 12, 2016

wkentaro Sep 12, 2016

Choose a reason for hiding this comment

k-okada Sep 12, 2016

Choose a reason for hiding this comment

k-okada Sep 12, 2016 • edited Loading

Choose a reason for hiding this comment

wkentaro Sep 12, 2016 • edited Loading

Choose a reason for hiding this comment

wkentaro Sep 12, 2016 • edited Loading

Choose a reason for hiding this comment

k-okada Sep 12, 2016

Choose a reason for hiding this comment

k-okada Sep 12, 2016

Choose a reason for hiding this comment

wkentaro Sep 12, 2016

Choose a reason for hiding this comment

k-okada commented Sep 12, 2016

wkentaro commented Sep 12, 2016

k-okada commented Sep 12, 2016 •

edited

Loading

k-okada Sep 12, 2016 •

edited

Loading

wkentaro Sep 12, 2016 •

edited

Loading

wkentaro Sep 12, 2016 •

edited

Loading