Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[jsk_rviz_plugins] add warn for deprecated jsk_rviz_plugins/PoseArrayDisplay #786

Merged
merged 2 commits into from
Oct 24, 2020
Merged

[jsk_rviz_plugins] add warn for deprecated jsk_rviz_plugins/PoseArrayDisplay #786

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f6001d3
add warn for deprecated jsk_rviz_plugins/PoseArrayDisplay
knorth55 Oct 24, 2020
21bef61
warn only for kinetic and upper version
knorth55 Oct 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions jsk_rviz_plugins/src/pose_array_display.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,9 @@ PoseArrayDisplay::~PoseArrayDisplay()

void PoseArrayDisplay::onInitialize()
{
#if ROS_VERSION_MINIMUM(1,12,0)
ROS_WARN("jsk_rviz_plugins/PoseArrayDisplay is deprecated. Please use rviz default PoseArrayDisplay plugin instead.");
#endif
MFDClass::onInitialize();
manual_object_ = scene_manager_->createManualObject();
manual_object_->setDynamic( true );
Expand Down Expand Up @@ -152,6 +155,9 @@ bool validateFloats( const geometry_msgs::PoseArray& msg )

void PoseArrayDisplay::processMessage( const geometry_msgs::PoseArray::ConstPtr& msg )
{
#if ROS_VERSION_MINIMUM(1,12,0)
ROS_WARN_THROTTLE(1.0, "jsk_rviz_plugins/PoseArrayDisplay is deprecated. Please use rviz default PoseArrayDisplay plugin instead.");
#endif
if( !validateFloats( *msg ))
{
setStatus( rviz::StatusProperty::Error, "Topic", "Message contained invalid floating point values (nans or infs)" );
Expand Down