Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure Travis CI to test on latest LTS Node.js #69

Merged
merged 1 commit into from
Jun 1, 2020

Conversation

kemitchell
Copy link
Member

Configure Travis CI to test on the latest LTS Node.js version.

@@ -1,6 +1,6 @@
---
language: "node_js"
node_js: [ "10", "11", "12", "13", "node" ]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why would you want to drop support for older node versions? testing on multiples happens in parallel, so it's not even slowing anything down (since you're at the parallelization threshold of 5)

12 is already the latest LTS, so it's already tested.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this should be an addition rather than a replacement.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since 14 isn't LTS yet, what you've got now is 10, 11, 12, 13, 12. In other words, I don't think any change is needed here; you're already testing everything above 10.

lts/* isn't a range, it selects the latest LTS version (which is 12)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Understood and intended. I want to catch LTS in the future without bumping .travis.yml all the time.

I suppose I should replace node, as well.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense. you also may want to add an explicit "engines" field - npx ls-engines :-)

@kemitchell kemitchell merged commit 62f4548 into master Jun 1, 2020
@ljharb ljharb deleted the travis-node-lts-wildcard branch June 1, 2020 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants