Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update license list to v3.8 (2020-02-09) #17

Closed
wants to merge 1 commit into from

Conversation

kemitchell
Copy link
Member

Copy link

@roryokane roryokane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I manually compared these 13 added licenses to the license-list-XML release notes for version 3.7 and 3.8 and confirm that they include all the added licenses. This PR’s additions don’t include two licenses/exceptions mentioned in those release notes, “GPL-3.0-linking-exception” and “GPL-3.0-linking-source-exception”, but those are exceptions, not licenses, so that’s fine.

If you were waiting for a third party’s approval, you have it. I think you can merge this and make a new release of spdx-license-ids.

(If you’re wondering how I found this PR and why I would care, I found this repo while trying to fix Yarn v1.22.4’s warning “License should be a valid SPDX license expression” for a license that was added in spdx-license-ids v3.0.5. I made local changes identical to yours before I noticed you already had a PR for it. I don’t personally care about any of the licenses in this PR, so no rush.)

@kemitchell
Copy link
Member Author

@roryokane thanks for this comment. I'm updating spdx-exceptions now.

@kemitchell
Copy link
Member Author

@shinnn spdx-exceptions@2.3.0 has the latest v3.8 SPDX data.

@kemitchell
Copy link
Member Author

Superseded by #19.

@kemitchell kemitchell closed this Sep 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants