Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update License List to v3.21, remove checking for ids end with + #33

Closed
wants to merge 2 commits into from

Conversation

cbsMartin
Copy link

  • All licenses that ends with + now are deprecated.
  • Update License List to v3.21

@kemitchell
Copy link
Member

Are these licenses not marked deprecated in SPDX's JSON?

@cbsMartin
Copy link
Author

Are these licenses not marked deprecated in SPDX's JSON?

From the official document with all SPDX license they are marked as deprecated but in current logic they are skipped.

@kemitchell
Copy link
Member

Oh, boy.

SPDX has done something drastic with their license IDs, and I've yet to read my way up on it. If + is now a valid identifier character, we are going to have fun times in the expression parser, too.

@kemitchell
Copy link
Member

I've reached out to SPDX for clarification.

I suspect, but do not yet know, that they added some license expressions to the license list, just for the purpose of deprecating them. That's expressing the idea that they would rather see "GPL-2.0-or-later" than "GPL-2.0+", but not that "GPL-2.0" itself is a valid license ID, such that "GPL-2.0++" would be a valid license expression.

We'll see.

@kemitchell
Copy link
Member

I've gone ahead and matched v3.21 of the SPDX list in spdx-license-ids@3.0.14. Will wait for response from them to decide what to do about filtering or not filtering IDs ending in +.

@kemitchell
Copy link
Member

Gary O'Neall from SPDX confirms there are in fact IDs that end in "+", and they are all deprecated now. I've cherry-picked your bf86ce2 and pushed to main.

@kemitchell kemitchell closed this Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants