Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Finish documentation from #86 #90

Closed
jsocol opened this issue Oct 15, 2015 · 1 comment
Closed

Finish documentation from #86 #90

jsocol opened this issue Oct 15, 2015 · 1 comment
Assignees
@jsocol
Milestone
1.1

Comments

@jsocol
Copy link
Owner

jsocol commented Oct 15, 2015

In #86, we decided that more documentation was necessary:

otherwise, i agree with the TODOs in that list, which are all documentation:

  1. put a ..warning: on the common keys list
  2. update the description of that behavior to be accurate, and probably add a prose note about empty values
  3. add a section to the security chapter on trusting GET/POST/header data
@jsocol jsocol self-assigned this Oct 15, 2015
@jsocol jsocol added this to the 0.7 milestone Oct 15, 2015
jsocol added a commit that referenced this issue Oct 30, 2015
@jsocol
Fix get/post/header key docs and add security note
3639ab9 
Fixes #90
@jsocol jsocol mentioned this issue Oct 30, 2015
Merged
@jsocol
Copy link
Owner Author

jsocol commented Oct 30, 2015

Closing in favor of #94

@jsocol jsocol closed this as completed Oct 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jsocol jsocol

Labels
None yet
Projects
None yet
Milestone
1.1
Development

No branches or pull requests
1 participant
@jsocol