Add RATELIMIT_IP_META_KEY setting #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a _get_ip() helper to ratelimit.core that gets the client IP from REMOTE_ADDR in one place, rather than multiple throughout the file.
jsocol
force-pushed
the
get-ip-helper
branch
2 times, most recently
from
0ebd045
to
0fd3148
Compare
The RATELIMIT_IP_META_KEY setting allows the application to control the source of truth for the client IP address for use with `key='ip'` or `key='user_or_ip'`. It enables an application to set this in a single place rather than setting `key='header:x-client-ip'`, which means this can be controlled for local development. Like other parameters in django_ratelimit, this setting accepts callables and paths to callables.
|
Running the library from the master branch with these changes in production for a month already - everything works perfectly. |
|
@SerhiyRomanov that's great to hear, thank you! I will try to prioritize getting together a new release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per some discussion in #208, and setting up a good place to resolve the issue raised in #209, adds a
_get_ip()helper toratelimit.core, and adds a setting to control the source of truth for the client IP address.