Cope with cache connection errors #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -389,6 +399,37 @@ def do_increment(request): | |||
| assert do_increment(req), 'Request should be rate limited.' | |||
| assert not_increment(req), 'Request should be rate limited.' | |||
|
|
|||
| @override_settings(RATELIMIT_USE_CACHE='connection-errors') | |||
| def test_is_ratelimited_cache_connection_error(self): | |||
There was a problem hiding this comment.
Mind dropping most of this test case and just calling is_ratelimited directly? The test it's copied from isn't a great test, and we can cover this case with something much simpler, more like the other test you added.
|
Thanks @tdhooper! Just a few issues. |
|
Thanks for the review @jsocol, back to you. |
|
Looks good! Mind squashing it all down to one commit? |
Ensure requests don't get rate limited and don't throw errors when a memcached instance is unavailable.
tdhooper
force-pushed
the
cope-with-cache-connection-errors
branch
from
6a541d7
to
fa3f0af
Compare
|
Can this be merged now? |
jsocol
added a commit
that referenced
this pull request
Oct 14, 2015
Cope with cache connection errors
|
Thanks @tdhooper! |
This was referenced Oct 14, 2015
|
Thanks, would you mind bumping the version number too? |
|
I just added this to the 0.7 milestone, along with the other things that have been merged since 0.6 and a few open issues, all bugs. (I pushed all the new features out to a new 0.8 milestone.) Before the version bump and release, we want to get those taken care of. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a memcached were to become unavailable, pages using the decorator would start throwing errors. This change copes with these errors and keeps pages available.