Add Django 1.10.x test environment and fix broken tests #239
Conversation
Tox now runs the test suite successfully under the latest Django 1.10.x As part of making the tests run under the new environement, the tests were updated to account for deprecated behaviour in Django. Also added Python 3.6 to django-waffle's tox test matrix. Closes jazzband#23.
|
Hey @djm, thanks! Waffle doesn't use tox on travis, though, it uses the |
|
Alternatively, if you wanted to incorporate @adamchainz's patch from #227, that would also work |
|
Ah! My bad assumption. I'll do that ASAP, check it works - then squash. Thanks @jsocol. |
|
Looks like we need to exclude py3.3 with >=1.9? One downside of tox is no parallel tests / individual combination reporting from the job, ah well. |
|
Hmm, I guess this is still open for Py3.5 travis-ci/travis-ci#4794 |
Tests being parallel isn't always faster, for many repos I've moved to having the grid in only tox it has ended up nearly the same time or even faster overall. You can do the coverage combining somehow in the tox file. |
Faster isn't the only thing (actually I think this run was faster than most) but when you use the Travis matrix you get the slightly cleaner report of whether each combination passed or failed, e.g. the last master build. But like I said, "ah well," not worth maintaining two grids. |
|
Ok, so this works, and keeps the builds separate but not repeated. tox-travis seems pretty handy. If you're happy with it @jsocol, I can squash. If not, let me know! Thanks again. |
|
This lgtm, thanks @djm! |
|
Awesome, thanks @jsocol :) |
|
"Squash and merge" is a pretty nice feature. Thanks again @djm! |
* Add Django 1.10.x test environment and fix broken tests Tox now runs the test suite successfully under the latest Django 1.10.x As part of making the tests run under the new environement, the tests were updated to account for deprecated behaviour in Django. Also added Python 3.6 to django-waffle's tox test matrix. Closes jazzband#23. * Update travis CI build to just use tox * Explicitly install Python versions before run * Exclude py3.3 from Django 1.9/1.10 tests
Hi James,
Just a small one here to get the project's test suite up to current speed.
Tox now runs the test suite successfully under the latest Django 1.10.x and Python 3.6 environments.
As part of making the tests run under the new environement, the tests were updated to account for deprecated behaviour in Django. Only thing of note really is that
render_to_responsewas removed in favour ofrenderasrender_to_responseis 'likely pending deprecation' as of Django 1.10.Thanks for all your work on this, we use it extensively at Yunojuno. If the 1.10 stuff could get a release on PyPI that'd be super; if there's anything blocking that just let us know.
Fixes #224.
cheers,
Darian