Openbsd arm64 and amd64 support #111
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We would like to pick up these changes and improve/simplify Jsoftware
support for BSD. RIght now we don't have the resources to vet this properly
and to finish off the current edges. We hope to have someone before year
end who will be responsible for exactly these kinds of pull requests. This
will be announced when we are ready.
Thanks for your contributions and also to Brian Callahan. We'll try to get
them included by year end and then should be in a position to more easily
stay current with contributions.
…On Sat, Oct 9, 2021 at 9:06 PM Aaron Ash ***@***.***> wrote:
Recently Brian Callahan made a J port for OpenBSD amd64:
https://briancallahan.net/blog/20210911.html
The details of his port patches are here:
https://marc.info/?l=openbsd-ports&m=163138993214367&w=2
I thought it would be nice for the main J repo to build on OpenBSD out of
the box without patches required.
This has been tested on an Intel i7-1165G7 laptop (Lemur Pro lemp10) and a
Raspberry Pi 4 8GB both running OpenBSD 7.0 (CURRENT snapshots).
As mentioned in the commit messages a fair few of the tsu.ijs tests
succeed but both architectures crash during or just after g128x7.ijs. Brian
Callahan mentions in his post that the gss.ijs test fails for him with his
port.
I've attempted to follow the existing code style in the build scripts even
though there's a little bit of repetition.
Are there any changes or cleanup required to get this merged?
------------------------------
You can view, comment on, or merge this pull request online at:
#111
Commit Summary
- OpenBSD GNU-Make is gmake
<0436ec6>
- Add OpenBSD arm64 support
<c48f3f6>
- Add OpenBSD amd64 support
<e5aaf7e>
File Changes
- *M* jsrc/cpuinfo.c
<https://github.com/jsoftware/jsource/pull/111/files#diff-1e37effc2b0db124f5baf3c6ac0c938b2573ddf64a1c226c328c7445a6ee62d1>
(6)
- *M* jsrc/js.h
<https://github.com/jsoftware/jsource/pull/111/files#diff-146f713370a196383bf14eb48d6be7e6073002d46c6b1fc985295925b7277837>
(8)
- *M* make2/build_all.sh
<https://github.com/jsoftware/jsource/pull/111/files#diff-96d9b019eae2601e402d271d1f7c363d6dc9b94acac74c1b7202408176cf6f24>
(13)
- *M* make2/build_jconsole.sh
<https://github.com/jsoftware/jsource/pull/111/files#diff-3b002af04558ac13aedf6fadc7da5fc7e186f0dcf654220d4bcbcee3b9fc95cf>
(18)
- *M* make2/build_jnative.sh
<https://github.com/jsoftware/jsource/pull/111/files#diff-f6761fd8d454f467e2474e8ccc03124dd6763dc27e39bea69662124c14e3f1bc>
(20)
- *M* make2/build_libj.sh
<https://github.com/jsoftware/jsource/pull/111/files#diff-e023d8fb4d46cb51281bba5ef1102ffb6cfb9052000796e6cfba3fa3749ada7a>
(51)
- *M* make2/build_tsdll.sh
<https://github.com/jsoftware/jsource/pull/111/files#diff-9be520f019c53b125a27557c55da474e95a5c821a91fb01813e61def97bf6736>
(26)
- *M* make2/cpbin.sh
<https://github.com/jsoftware/jsource/pull/111/files#diff-834ab2e84d461cbdd06f7bd484f75689f891cf35dbf87063972873c3d297466d>
(10)
Patch Links:
- https://github.com/jsoftware/jsource/pull/111.patch
- https://github.com/jsoftware/jsource/pull/111.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#111>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEBRCHW2XOWIY2MW4NHAR43UGDRKTANCNFSM5FV36MJA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
|
Thanks @eiverson, in the mean time I'll try to narrow down the failing tests. |
This was referenced Oct 30, 2021
Builds and runs successfully on OpenBSD arm64 on an rpi4. A lot of the tests in tsu.ijs succeed but eventually that script crashes with a core dump in (or after) test/g128x7.ijs.
J now builds and runs on OpenBSD amd64 in nonavx, avx and avx2 mode. The tsu.ijs tests run part of the way but crash in g128x7.ijs with: jconsole:.../jsource/jlibrary/bin/libjavx2.so: undefined symbol 'sha1_block_data_order' ld.so: jconsole: lazy binding failed! Killed
Gnu-make is `gmake` on openbsd. `uname -m` returns 'amd64' instead of x86_64.
|
Rebased onto the latest jsource master branch and tested successfully again on openbsd x86_64 (intel i7-1165G7) and arm64 (rpi4). |
cdburke
force-pushed
the
master
branch
10 times, most recently
from
c6377af
to
1528769
Compare
cdburke
force-pushed
the
master
branch
3 times, most recently
from
b0d5e67
to
2455187
Compare
|
openbsd for amd64 and arm64 should work and run test suite clean now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently Brian Callahan made a J port for OpenBSD amd64: https://briancallahan.net/blog/20210911.html
The details of his port patches are here: https://marc.info/?l=openbsd-ports&m=163138993214367&w=2
I thought it would be nice for the main J repo to build on OpenBSD out of the box without patches required.
This has been tested on an Intel i7-1165G7 laptop (Lemur Pro lemp10) and a Raspberry Pi 4 8GB both running OpenBSD 7.0 (CURRENT snapshots).
As mentioned in the commit messages a fair few of the tsu.ijs tests succeed but both architectures crash during or just after g128x7.ijs. Brian Callahan mentions in his post that the gss.ijs test fails for him with his port.
I've attempted to follow the existing code style in the build scripts even though there's a little bit of repetition.
Are there any changes or cleanup required to get this merged?