Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace AppVeyor with GitHub Actions #1294

Merged
merged 3 commits into from Sep 17, 2023
Merged

Replace AppVeyor with GitHub Actions #1294

merged 3 commits into from Sep 17, 2023

Conversation

bkoelman
Copy link
Member

@bkoelman bkoelman commented Jul 29, 2023

AppVeyor has served us well for many years, but its development has stalled while the competition has caught up and improved far beyond what AppVeyor provides. And the Linux workers are magnitudes faster.

AppVeyor GitHub Actions
Build duration 55 min 20 min
Max parallel jobs 1 20 (macOS 5)
Job timeout 1 hour 6 hours (workflow 35 days)
Run subsequent steps after timeout no yes (enables to collect logs after hang)
Artifact/NuGet package retention 30 days/unlimited 90 days/unlimited
Build worker image updates few times per year weekly
Security undocumented very high
Timings per build step no yes
Test summaries no yes
Rich ecosystem of custom actions no yes
Run on .NET preview versions manual built-in
Recycle NuGet API key requires commit requires no commit
Suppress notification for canceled jobs yes no
Remote Desktop/SSH into build worker yes no

A bug fix in the coverage reporting causes the reported -3.8% below.

@json-api-dotnet json-api-dotnet deleted a comment from codecov bot Aug 5, 2023
@json-api-dotnet json-api-dotnet deleted a comment from codecov bot Aug 6, 2023
@json-api-dotnet json-api-dotnet deleted a comment from codecov bot Aug 13, 2023
@bkoelman bkoelman force-pushed the setup-github-actions branch 3 times, most recently from cfcc9dd to c7d078e Compare August 18, 2023 09:41
@bkoelman bkoelman force-pushed the setup-github-actions branch 2 times, most recently from 9202705 to 5220148 Compare September 5, 2023 22:40
@codecov
Copy link

codecov bot commented Sep 17, 2023

Codecov Report

Merging #1294 (6e30e3d) into master (f38a812) will decrease coverage by 3.80%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1294      +/-   ##
==========================================
- Coverage   96.82%   93.02%   -3.80%     
==========================================
  Files          21      268     +247     
  Lines         598     8777    +8179     
==========================================
+ Hits          579     8165    +7586     
- Misses         19      612     +593     

see 247 files with indirect coverage changes

@bkoelman bkoelman changed the title Add GitHub Actions workflow Replace AppVeyor with GitHub Actions Sep 17, 2023
@bkoelman bkoelman force-pushed the setup-github-actions branch 5 times, most recently from 3be365d to 857a785 Compare September 17, 2023 15:03
@bkoelman bkoelman marked this pull request as ready for review September 17, 2023 15:38
@bkoelman bkoelman merged commit 6afbff7 into master Sep 17, 2023
13 checks passed
@bkoelman bkoelman deleted the setup-github-actions branch September 17, 2023 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant