Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standard Incompatible with IE8 #621

Closed
ben-crowhurst opened this issue May 15, 2015 · 14 comments · Fixed by #627
Closed

Standard Incompatible with IE8 #621

ben-crowhurst opened this issue May 15, 2015 · 14 comments · Fixed by #627
Labels
extension Related to existing and proposed extensions as well as extensions in general

Comments

@ben-crowhurst
Copy link

HTTP PATCH Method not supported :(

http://bugs.jquery.com/ticket/13240

@tanmayambre
Copy link

+1

@steveklabnik
Copy link
Contributor

While I'm sympathetic to browser support, our primary audience isn't browsers, it's other API clients.

We can't not use PATCH here, as it's the correct HTTP verb.

@ben-crowhurst
Copy link
Author

May the standard host a section stating HTTP PUT is ok as long as its a complete resource document?

@ziyualexanderwang
Copy link

+1

2 similar comments
@gogs2020
Copy link

+1

@juniorhamish
Copy link

+1

@gr0uch
Copy link
Contributor

gr0uch commented May 15, 2015

Seems like a popular request. For browsers that don't support PATCH, they should be able to send custom headers, such as X-Request-Method to bypass the method problem.

I disagree that the primary audience isn't browsers, considering that Ember Data is a major consumer. I agree that it should use PATCH though.

@shotsyjr
Copy link

+1

@steveklabnik
Copy link
Contributor

I certainly don't want to talk down the Ember Data case, it is very important! I just mean correctness comes first, then possible hacks for compatibility.

@hhware
Copy link
Contributor

hhware commented May 15, 2015

May the standard host a section stating HTTP PUT is ok as long as its a complete resource document?

@ben-crowhurst, PUT is OK for anything, see http://jsonapi.org/faq/#wheres-put

@ChrisDavison
Copy link

+1

@dgeb
Copy link
Member

dgeb commented May 15, 2015

I don't think we need anything normative in the spec to allow for this. This seems like a perfect candidate for an extension, which would allow servers to eventually phase out support.

@ethanresnick
Copy link
Member

I'm +1 on @dgeb's and @steveklabnik's sentiment that we shouldn't spend too much effort worrying about this, as we're doing the correct thing and the problem will solve itself as IE8 fades out over time. That said, a recommendation for how to solve this (if there's a simple way) could be a really big win for the spec adoption at relatively little cost.

For example, what if we recommended that clients wanting to do updates over PUT use the X-HTTP-Method header with their requests to instruct the server to treat the PUT as a PATCH, and we could recommend that server's support this header on PUT endpoints. Again, it'd just be a recommendation (no base spec changes) but could help adoption considerably.

@mandalae
Copy link

+1

ethanresnick added a commit to ethanresnick/json-api-1 that referenced this issue May 18, 2015
Note that this only recommends _how_ to support PATCHless clients if
the server wants to support them at all. It _doesn’t_ go so far as to
recommend that they should support them.

Closes json-api#621.
ethanresnick added a commit to ethanresnick/json-api-1 that referenced this issue May 18, 2015
Note that this only recommends _how_ to support PATCHless clients if
the server wants to support them at all. It _doesn’t_ go so far as to
recommend that they should support them.

Closes json-api#621.
@dgeb dgeb added the extension Related to existing and proposed extensions as well as extensions in general label May 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
extension Related to existing and proposed extensions as well as extensions in general
Projects
None yet
Development

Successfully merging a pull request may close this issue.