-
Notifications
You must be signed in to change notification settings - Fork 834
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Always return "included" where "include" has been requested #1236
Conversation
This is great. Just so we're not repeating the clause "If an endpoint supports the Something like:
|
Opted to leave the second list item as-is. Good call on the repetition. |
I realize I'm really nitpicking here, and it's probably more important to just get this merged, but something about the wording quoted above bothers me. Specifically, I think having an Your wording seems to suggest, though, that the response is already a compound document, which it isn't until the Can we stick with my wording for the first bullet, and then I'll get this merged? |
@ethanresnick Agreed. |
Great. Merged! |
* Always return "included" where "include" has been requested * Less repetition; clarify empty response * Fixed em-dash; wrapping * Feedback change
* json-api-gh-pages: (259 commits) jsonapi-realizer is a new server side hander, intended to be a sister to jsonapi-serializers (json-api#1267) Added DenaliJS to the Node framework list (json-api#1264) Added Vox to iOS implementations (json-api#1262) Update scala-jsonapi link (json-api#1263) added sarala javascript packages to implementations (json-api#1260) Add SimpleJSONAPIClient to Ruby implementations (json-api#1257) Removed py-jsonapi (json-api#1258) Move fast_jsonapi to it\'s proper place in the ruby server list (json-api#1256) Clarify pagination links in relationship object (json-api#1251) move safrs to server libraries (json-api#1253) Add fast_jsonapi to Ruby Lists (json-api#1252) JSON API Playground link added to implementations (json-api#1248) Add SAFRS to list (json-api#1250) Always return "included" where "include" has been requested (json-api#1236) ngx-jsonapi added to implementations (json-api#1228) PHP library for JSON API + Doctrine add @crnk/angular-ngrx implementation Add jsonapi-mock to implementations Add raml-json-api to implementations Clarify pending async process response json-api#1223 ...
#1230
One additional thing that may be worthwhile is reiterating that the
included
param must always be an array, and that an empty array should be returned when no additional resources are available to add to the response.Open to feedback. :)