-
Notifications
You must be signed in to change notification settings - Fork 836
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove extension mechanism from base spec. #660
Conversation
Instead of rushing the extension mechanism into the 1.0 release, we are marking it as experimental and removing it from the base spec. This allows us to solidify the extension concepts for a future release.
Okay, so will extensions use a completely different media type eventually, or how does this work in terms of 1.0 implementations and their lack of awareness of the |
1.0 client implementations won't be aware of the We should probably explicitly declare that media type parameters must be ignored. I was debating where to place such a statement. |
I am working on wording in the base spec regarding the |
This allows for future compatibility with an extension mechanism that uses `ext` to specify an extension and possibly uses other paramters for extension negotiation.
I've introduced a media type negotiation section in the base spec - please review carefully 85d8386 |
[as discussed in the base specification](/format#extending). | ||
Official and custom extensions to the specification are discussed below. | ||
* [Official](#official-extensions) and [custom](#custom-extensions) extensions | ||
are in development. The `supported-ext` and `ext` media type parameters can |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we start the sentence that says "The supported-ext
and ext
..." with the clause "Currently, ", to suggest that the parameters may change?
@dgeb Thanks for punting on extensions for now, so that we can both get the mechanism right and still get 1.0 out tonight! That seems like the right call. A couple other things:
|
Nicely done @dgeb! I'm really glad we've decided to take this approach. 👍 from me. |
Remove extension mechanism from base spec.
Thanks @dgeb! Also, any comments on #660 (comment)? |
@ethanresnick see #660 (comment) We now have a little time to ensure the correctness and readability of this section. |
The new section on media type negotiation distinguishes between |
The intent is to reserve the |
@dgeb Sorry, I phrased that poorly. What I mean is, why not put a blanket ban on all parameters? I'm assuming this is because we want to allow APIs to use the same header for their own stuff, too. This is fine, but it also implies that JSON API will never use anything besides |
@bintoro Given the current requirements on the server, I think this could more accurately be said "JSON API will never use another media type parameter besides Since this PR is now merged, please open an issue to discuss this further if you like. I'm not sure it's a major problem, but we should be clear-eyed about the implications and alternatives. |
Instead of rushing the extension mechanism into the 1.0 release, we are
marking it as experimental and removing it from the base spec.
This allows us to solidify the extension concepts for a future release.