Building a project which uses json-c with flag -Wcast-qual causes compilation errors

[svagionitis]

I use json-c in one project which one of the compiler flags is -Wcast-qual. I use the macro json_object_object_foreach and I get the following error when compiling

error: cast from 'const void *' to 'struct json_object *' drops const qualifier [-Werror,-Wcast-qual]
    json_object_object_foreach(body_json, key, val)
    ^
/usr/include/json-c/json_object.h:320:31: note: expanded from macro 'json_object_object_foreach'
                        val = (struct json_object*)entry ## key->v; \
                                                   ^

This happens because the value, in the lh_entry, is set as const but in the macro json_object_object_foreach the value is type casted as non-const.

Now, removing the const qualifier from the value in lh_entry fixes the issue, but I am not familiar with the json-c code base and I don't think that might be the proper solution.

[hawicz]

No, the const should stay there. I've got some changes that should improve the situation, which I'll be pushing shortly.

[svagionitis]

Cool, thanks @hawicz for your quick reply and fix.