Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fails to parse valid json #259

Closed
alexukr opened this issue Aug 11, 2016 · 0 comments
Closed

Fails to parse valid json #259

alexukr opened this issue Aug 11, 2016 · 0 comments

Comments

@alexukr
Copy link

alexukr commented Aug 11, 2016

One of the recent changes broke parsing.
E.g. json_tokener_parse returns NULL for the following valid json: {"a":"b"}

I left the comment to the following commit to show where the bug might be:
0ad8764#diff-c52934e6a3f24960bf8218b91f580befR175

Basically json_object_get() now always returns NULL.
hawicz added a commit that referenced this issue Aug 11, 2016
@hawicz
Revert bogus change to json_object_get() made in f40b08d that caused …
4d62de3 
…it to always return NULL. (Issue #259)

Also undo NULL check in json_tokener_set_flags(): it's not at all valid toi
 try to set flags on a NULL pointer, and doing so should not be silently
 ignored.
@hawicz hawicz closed this as completed Aug 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hawicz @alexukr