Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VERBOSE=1 make check; tests/test_util_file.test.c and tests/test_util_file.expected out of sync #313

Closed
JungHong opened this issue Apr 1, 2017 · 3 comments

Comments

@JungHong
Copy link

JungHong commented Apr 1, 2017

  1. on cygwin64 on windows 8.1,
    autoredonf --version --> 2.69
    autoconf --version -----> 2.69
    automake --version ---> 1.15
    gcc --version ---> 5.4.0
    libtool --version --->2.4.6

  2. many changes to configure.ac and Makefile.am were required for autoreconf -vi and ./configure to complete without errors. Do you want the changes that were needed for autoreconf -vi and ./configure to complete without errors?

And if so, how do you want the changes.

  1. 'make check' reported fail in tests/test_util_file.c
    'VERBOSE=1 make check'
    shows that there are no errors in ./tests/testSubDir/test_util_file.test/test_util_file.out It was just that the distributed file, /root/json-c/tests/test_util_file.expected is out of sync.

The following solved this problem
cp ./tests/testSubDir/test_util_file.test/test_util_file.out /root/json-c/tests/test_util_file.expected

  1. Now 'make check' executes without errors.

JPH

@ploxiln
Copy link
Contributor

ploxiln commented Apr 1, 2017

Instead of autoreconf -vi you should run autogen.sh which contains the important argument -Iautoconf-archive/m4.

Copying the actual output to the reference expected output will of course make it match. But will it be correct ... you'll have to look at the actual differences to figure out.

@hawicz
Copy link
Member

hawicz commented Apr 8, 2017

If there are changes beyond simply specifying the -I option, please let us know what they are.

As for test_util_file, what are the differences?

@hawicz
Copy link
Member

hawicz commented Apr 13, 2017

Can't do anything w/o details, closing.

@hawicz hawicz closed this as completed Apr 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants