Issue #338, add json_object_add_int functions #363
Conversation
| * @param val the value to add | ||
| * @returns 1 if the addition succeded, 0 otherwise | ||
| */ | ||
| JSON_EXPORT int json_object_add_int(struct json_object *obj, int val); |
There was a problem hiding this comment.
maybe more of a preference [from me] here, but, keeping the name json_object_inc_int() [like mentioned in issue #338 ] or similar, could be a good idea, because it makes it clearer that it's incrementing an int value;
in the context of libjson-c a name that like json_object_add_xxx reminds me of the json_object_object_add() or json_object_array_add() functions where a JSON object is added to a another JSON object
i'd also rename the int val param to int inc
and you can also create a convenience macro called json_object_dec_int() where
#define json_object_dec_int(x,y) json_object_inc_int(x, -(y))
but these are all just preferences/thoughts :)
|
Merging as-is first, but I'm going to consolidate the 32/64-bit versions shortly. |
|
Also, I like @commodo's suggestion of keeping the "inc" in the name, so I'll rename it. |
|
Actually, to be consistent with other methods that mutate existing objects (e.g. json_object_array_sort) I'm going to use json_object_int_inc() here. |
|
Done in commit 3628f16 |
This adds json_object_add_int and json_object_add_int64 functions, instead of the increment functions requested in #338 since add functions are more general.