New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #338, add json_object_add_int functions #363
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,41 @@ | ||
#include <assert.h> | ||
#include <stdio.h> | ||
|
||
#include "json.h" | ||
|
||
int main(int argc, char **argv) | ||
{ | ||
json_object *tmp = json_object_new_int(123); | ||
json_object_add_int(tmp, 123); | ||
assert(json_object_get_int(tmp) == 246); | ||
json_object_put(tmp); | ||
printf("INT ADD PASSED\n"); | ||
tmp = json_object_new_int(INT32_MAX); | ||
json_object_add_int(tmp, 100); | ||
assert(json_object_get_int(tmp) == INT32_MAX); | ||
json_object_put(tmp); | ||
printf("INT ADD OVERFLOW PASSED\n"); | ||
tmp = json_object_new_int(INT32_MIN); | ||
json_object_add_int(tmp, -100); | ||
assert(json_object_get_int(tmp) == INT32_MIN); | ||
json_object_put(tmp); | ||
printf("INT ADD UNDERFLOW PASSED\n"); | ||
tmp = json_object_new_int64(321321321); | ||
json_object_add_int(tmp, 321321321); | ||
assert(json_object_get_int(tmp) == 642642642); | ||
json_object_put(tmp); | ||
printf("INT64 ADD PASSED\n"); | ||
tmp = json_object_new_int64(INT64_MAX); | ||
json_object_add_int64(tmp, 100); | ||
assert(json_object_get_int64(tmp) == INT64_MAX); | ||
json_object_put(tmp); | ||
printf("INT64 ADD OVERFLOW PASSED\n"); | ||
tmp = json_object_new_int64(INT64_MIN); | ||
json_object_add_int64(tmp, -100); | ||
assert(json_object_get_int64(tmp) == INT64_MIN); | ||
json_object_put(tmp); | ||
printf("INT64 ADD UNDERFLOW PASSED\n"); | ||
|
||
printf("PASSED\n"); | ||
return 0; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
INT ADD PASSED | ||
INT ADD OVERFLOW PASSED | ||
INT ADD UNDERFLOW PASSED | ||
INT64 ADD PASSED | ||
INT64 ADD OVERFLOW PASSED | ||
INT64 ADD UNDERFLOW PASSED | ||
PASSED |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
test_basic.test |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe more of a preference [from me] here, but, keeping the name
json_object_inc_int()
[like mentioned in issue #338 ] or similar, could be a good idea, because it makes it clearer that it's incrementing an int value;in the context of
libjson-c
a name that likejson_object_add_xxx
reminds me of thejson_object_object_add()
orjson_object_array_add()
functions where a JSON object is added to a another JSON objecti'd also rename the
int val
param toint inc
and you can also create a convenience macro called
json_object_dec_int()
wherebut these are all just preferences/thoughts :)