add uint64 data to json-c

[dota17]

Many people want to add uint64 data into json-c in #520, #326, #143. I believe it is necessary and useful, so I make it in this commit. Review please.

Added content:

1. Add uint64_t c_uint64 data type and other related parameters, such as json_type_uint.
2. Add new functions:

• json_object_uint_to_json_string()
• json_object_new_uint64
• json_object_get_uint64()
• json_object_set_uint64()
• json_object_uint_inc()
• json_parse_uint64()

3. Modify functions: (add uint64_t data/type )

• json_object_set_serializer(),
• json_object_get_boolean()
• json_object_get_int()
• json_object_get_int64()
• json_object_get_double()
• json_object_equal()
• json_c_shallow_copy_default()

4. Modify json_tokener_parse_ex()function:

if the number is double, just parse it as double.
if the number is not double, then distinguish if it is negative.
----if it is negative, parse it as int64 data.
----if it is not negative , parse it as uint64 data. Last, judge numuint64 <= INT64_MAX,
--------if yes, transfer it as int64 data.

5. Add related test cases.
   test_cast.c, test_compare.c , test_int_add.c, test_parse.c, test_parse_int64.c, test_set_value.c.

As you can see, I have modified many files and achived adding-uint64. Welcome your comments and suggestions

[hawicz]

Your changes look decent, but defining a whole new json_type_uint seems like an unnecessarily large breaking change, just to get one additional bit of magnitude.
Yes, that's a fairly straightforward way of adding this support, but I'm thinking that it might be a bit better to keep just a single json_type_int type exposed, and distinguish the actual width of the number only internally within the library. e.g. int64_t c_int64; in the json_object structure would instead turn into something like:

union data {
    ...
    struct {
        union {
            int64_t c_int64;
            uint64_t c_uint64;
        } u_int;
        int is_unsigned;
    } c_int;
    ...
} o;

Which would allow things like json_object_get_type() to continue to return json_type_int, while also providing a easier way forward for future updates to expand the available magnitude beyond 64-bits (perhaps even arbitrary precision integers).

[dota17]

ok, I know your meanings. It's really a good solution, I will try to change it.

[hawicz]

Thanks. I expect this will have the side-effect of making all places where we currently refer to c_int64 a bit more involved, but I'm hoping that ends up not being too bad. If you're going to try this then I guess we'll see. :)

[dota17]

All this is a digression, could you open the coveralls right for json-c, ha-ha. It is a interesting tool.

[hawicz]

I think this could still use a couple more tweaks (i.e. improved assert calls, a bit of simplification in object_equal), but it's good enough to merge. I'll make those other changes later today.

[dota17]

ok, thx.

[hawicz]

Done (commit b3296e7)

[dota17]

good，It's improved a lot. And #520 , #326 , #143 maybe should be closed.

[andrewhodel]

Can't you just input an int64 then cast it as unsigned when you read it?

[hawicz]

Input where, in your json input? That means you'd have things like:

{ "foo": -9223372036854775808,
   "bar":  -1 }

when you really mean:

{ "foo": 9223372036854775808,
   "bar": 18446744073709551615 }

Which would be quite confusing, not to mention not at all interoperable with any other json implementation that might support numbers that large.

[andrewhodel]

Sure, but you might need to support version 0.12 not 0.15 Andrew

…

On Tue, Mar 23, 2021 at 1:33 PM Eric Hawicz ***@***.***> wrote: Input where, in your json input? That means you'd have things like: { "foo": -9223372036854775808, "bar": -1 } when you really mean: { "foo": 9223372036854775808, "bar": 18446744073709551615 } Which would be quite confusing, not to mention not at all interoperable with any other json implementation that might support numbers that large. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#542 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAFVCSLTSNRL6QDE7VZXQCTTFDNJDANCNFSM4K3AJNNA> .