CMake: Do not install config.h, as it is not a public header file. #585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Installing this file will lead to clashes with applications, that link against json-c and include their own build-time config.h. Anyways, that particular header file is not needed to build and link against json-c.
This done for the same reasons as we do not ship config.h.
This done for the same reasons as we do not ship config.h.
This done for the same reasons as we do not ship config.h.
This done for the same reasons as we do not ship config.h.
besser82
force-pushed
the
topic/besser82/config_h_no_public
branch
from
4f62839
to
9a0c54e
Compare
This is done to avoid possible undesired clashes by too generic naming.
|
Excluding config.h is fine, but we can't do this with arraylist.h, printbuf.h nor linkhash.h. For better or for worse, they're part of the public API and have been for some time now. This would be a good item to put on the todo list for a major 1.0 release though. |
hawicz
added a commit
that referenced
this pull request
Apr 21, 2020
hawicz
added a commit
that referenced
this pull request
Apr 21, 2020
(cherry picked from commit 8b511c4)
|
config.h is now excluded from install on master and the json-c-0.14 branch. Since that's the best we can do at the moment, I'm closing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Installing this file will lead to clashes with applications, that link against json-c and include their own build-time config.h.
Anyways, that particular header file is not needed to build and link against json-c.
Likewise any public headers with generic names should be prefixed with
json_cto avoid possible undesired clashes.Please backport these commits to 0.14 as the current release may break building any apllication randomly for no obvious reason for this header file being present.