Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Test for get int functions #796

Merged
merged 2 commits into from
Nov 17, 2022

Conversation

fedefrancescon
Copy link

Added basic tests for:

  • json_object_get_int
  • json_object_get_int64
  • json_object_get_uint64

@fedefrancescon
Copy link
Author

Related to this already fixed issue: #792

I've added some tests for get int functions.
I have some doubts about the checks for ERANGE that could be realated to this comment: 57bef5e#r88252910

Could this be useful? Any feedback or suggestion would be much appreciated and I'll be glad to add/fix what's spotted out.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 87.029% when pulling 1a2fdc4 on fedefrancescon:test-add-int-get into bc35549 on json-c:master.

@hawicz
Copy link
Member

hawicz commented Nov 17, 2022

Sure, these tests seem reasonable. Thanks!

@hawicz hawicz merged commit 79c1472 into json-c:master Nov 17, 2022
@fedefrancescon fedefrancescon deleted the test-add-int-get branch November 17, 2022 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants