Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should I treat this as the primary fork? #4

Closed
jstnlef opened this issue Jan 3, 2018 · 5 comments
Closed

Should I treat this as the primary fork? #4

jstnlef opened this issue Jan 3, 2018 · 5 comments

Comments

@jstnlef
Copy link

jstnlef commented Jan 3, 2018

I'm looking to write an Angular4/5 wrapper for this project and was wondering if I should use this as the starting point or the original jdorn one?
@loganvolkers
Copy link
Contributor

The original project is not accepting pull requests and hasn't had contributions in awhile.

We are trying to contact the original author to officially move the project: jdorn/json-editor#800

In the meantime, I would suggest that you build off this fork, but we have yet to publish to NPM (see #5)

@jstnlef
Copy link
Author

jstnlef commented Jan 5, 2018

Sounds good. Thanks

heathdutton referenced this issue in heathdutton/json-editor Jan 10, 2018
@Kanabanarama
Copy Array Element Button (#4)
b71ffe1
heathdutton referenced this issue in heathdutton/json-editor Jan 10, 2018
@xvaara
Merge commit '27b611a766daf680f60f8b14779284bd9775175c'
b9ee823 
* commit '27b611a766daf680f60f8b14779284bd9775175c': (44 commits)
  Added selenium tests with mocha
  Revert "Merge branch 'mehmetb-master' into develop"
  Include expanded schemas options to include refs (dmstr-forks#27)
  Add option to have info buttons (dmstr-forks#24)
  Implemented template support for 'rel' property on href's schema jdorn#606 (dmstr-forks#17)
  Update multiple.js (dmstr-forks#21)
  Fixed to expand refs before creating root editor (dmstr-forks#18)
  fix for issue 627 - selectize dropdown causes prop to dissapear - and issue 538 - create hardcoded to true (dmstr-forks#19)
  Issue 488 fix disabled fields get enabled when using properties dropdown (dmstr-forks#22)
  Resolved merge conflicts
  update submitted json when editing select fields via json manually to (dmstr-forks#29)
  Copy Array Element Button (#4)
  Cleaning with innerHTML='' causes issues on IE. So clean children one by one with removeChild (dmstr-forks#11)
  use hasOwnProperty instead of requiring a "true" value for startval (dmstr-forks#30)
  added check for whether label is defined for checkbox (#8)
  Respect "minimum"/"maximum" and "exclusiveMinimum/Maximum" (#7)
  Undefined variable issue when using template (dmstr-forks#15)
  Fix typo (dmstr-forks#31)
  Fix for crash given schema {"enum":[null]} (dmstr-forks#26)
  add option for lodash templates (#5)
  ...
@danielo515
Copy link

In the meantime, what are the fixes/new features this fork adds?

@schmunk42
Copy link
Collaborator

@danielo515 We merged over a dozen PRs from the original repo, please see https://github.com/json-editor/json-editor/commits/master - but it's time to create a real CHANGELOG.md now 😄

@loganvolkers
Copy link
Contributor

Closing this issue. See #5 for progress on making this fork official.

murb referenced this issue in murb/json-editor May 25, 2018
@heathdutton
Merge pull request #4 from pmadril/FixMissingBracket
29e81b3 
Fix missing bracket
Ruabaer pushed a commit to Ruabaer/json-editor that referenced this issue Apr 2, 2020
@Kanabanarama @Ruabaer
Copy Array Element Button (json-editor#4)
896ca98
schmunk42 pushed a commit that referenced this issue Aug 25, 2020
@fredmaggiowski
Merge pull request #4 from mia-platform/align-with-master-origin-json…
210965b 
…-editor

Align with master origin json editor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@schmunk42 @loganvolkers @jstnlef @danielo515