Valid example file was invalid! #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DimitriPapadopoulos
force-pushed
the
fix_fab533e
branch
from
37d9454
to
935b2d7
Compare
|
See discussion in #73 - it may not be valid according to the JSON specification, but the file is named as such because it is intended to be accepted by this library. EDIT: Perhaps it should have |
|
That's the file I added recently. I didn't intend it to have the comma, it should just check Unicode support, not extensions. |
Fix valid-0013.json added by fab533e (json-parser#125)
DimitriPapadopoulos
force-pushed
the
fix_fab533e
branch
from
935b2d7
to
b4bb0cc
Compare
|
Ah I see, I forgot the file was introduced by you to begin with! Thanks for reminding me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
valid-0013.jsonadded by fab533e (#125)