FIX: build warning - cast from pointer to integer of different size #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While libm can be linked on generating final executable, it's still preferred to link it against the library itself to better represent the dependency hierarchy.
To prevent warnings in modern compilers
LB--
requested changes
Aug 7, 2021
There was a problem hiding this comment.
I am confused by the number of different commits, it looks like there are a lot of changes unrelated to the original purpose of this PR. Would you be able to reduce it back down to just the changes necessary for fixing the 64-bit pointer/int conversion issues?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build gives a warning (or breaks, using
-Werror) on Ubuntu for a Windows 64 bit target using thex86_64-w64-mingw32-gcccompiler. Error isjson.c:156:42: error: cast from pointer to integer of different size [-Werror=pointer-to-int-cast]Changing the type cast from
unsigned longtouintptr_tprevents the warning and should be cross-platform.