Rebase and update node branch #251
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* develop: (105 commits) Port to draft4. Fixed incorrect negative description of a sub test Minor shuffling. updated node.js info in README.md Add the README note on develop. JavaScript should written in upper camel case added ajv validator to readme Add another Go implementation Update pattern.json Update ref.json Add valid instances for escaped ref tests Add a test that checks for implicit anchoring Add jsen to the list of validators Use tox to run tests Add test case for protocol-relative uri validation [README] JSONSchema.swift uses these tests too Revert "Add jon, JSON parser for the fishshell." Add jon, JSON parser for the fishshell. Add new Rust library to the list Add new haskell implementation. Add json-schema-benchmark to list of users of this test suite Added Newtonsoft.Json.Schema implementation Added skeemas to list of suite users Make the implementation list a bit less unwieldy now that it's so long (hooray!) Add request-validator as a user of the test suite Update README.md Add tests for additionalProperties by itself. Added tests around the default property Added the json-schema ruby gem to the list of libraries using the test suite Applies to Draft4 as well. Check comparisons for very negative numbers as well. jsck uses JSON Schema Test Suite fixed maxLength test case Add a test for large int comparisons. Add a note to the README about running sanity checks. Shorten the descriptions slightly. Add string length tests for supplementary Unicode code points As per the spec, only dotted-quad is an acceptable format for IPv4 addresses. add json-schema-valid to list of validators add 'forbidden property' test (not with blank schema) Add the enum/required test to draft4 too Add tests for required/not required values with enums Add Jsonary and tv4 to the list Added Jassi library to the list. Add a test for valid URI reference, but invalid URI (which is not valid overall). patternProperties are not additionalProperties in draft3 either. add test to draft4 that checks that patternProperties are not counted as additionalProperties added entry for Dart Added z-schema to the list Update README.md ...
Adds ex_json_schema validator for Elixir
and associated tests.
Check that a string of "1" is not a number
Add league/json-guard implementation for PHP
Add Clojure json-schema to users
…-required Test required ignores non objects
Extract the schema for tests into a JSON file.
Added Manatee.Json as .Net implementor.
Add test for properties named $ref
schema What happens if you specify items as an array of types, but you don't include a value for every type? Right now we have no tests for that. We also don't have a test for when there are more values than defined item types.
Add postgres-json-schema
…ests Added tests for items when data contains more or less types than the schema
… false for draft 3 and 4
Add optional check for non-ECMA 262 regular expressions
When $ref is present other keywords should be ignored
* develop: Add optional check for non-ECMA 262 regular expressions add postgres-json-schema Added tests for items when data contains more or less types than the schema Added Manatee.Json as .Net implementor. Add test for properties named $ref Extract the schema for tests into a JSON file. Test required ignores non objects Add Clojure json-schema to users Add league/json-guard implementation for PHP Also check string "1" is not a number in draft 4 Check that a string of "1" is not a number Adds ex_json_schema validator for Elixir
Testing closing Z after time-zone offset for date-time
Fix broken indentation in enum.json
Add Justify as a suite user to README.md
Added test for additionalProperties
|
Hi, thanks a lot. As is this is quite hard to review unfortunately -- is it possible you can do this in 2 steps -- the first one should just rebase, no changes to node-related things, which should be easy to spot check, and then we can discuss the changes that you're making separately? They seem sensible from a brief glance, but it's hard to review when everything is mixed together. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.