Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test $dynamicRef extensible tree #521

Merged
merged 1 commit into from Oct 16, 2021
Merged

Test $dynamicRef extensible tree #521

merged 1 commit into from Oct 16, 2021

Conversation

olegshtch
Copy link
Contributor

Add test from Appendix C. Example of recursive schema extension of the draft.

@jdesrosiers
Copy link
Member

Thanks for the contibution @olegshtch. Can you move this test to the dynamicRef.json file. It doesn't need to be by itself.

@olegshtch
Copy link
Contributor Author

@jdesrosiers Yes, moved it.

jdesrosiers
jdesrosiers approved these changes Oct 14, 2021
View reviewed changes
Copy link
Member

@jdesrosiers jdesrosiers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but I'll wait to merge in case anyone else has comments.

@olegshtch olegshtch mentioned this pull request Oct 14, 2021
Open
@Julian
Copy link
Member

Julian commented Oct 14, 2021

Think makes sense to me too.

karenetheridge
karenetheridge approved these changes Oct 16, 2021
View reviewed changes
Copy link
Member

@karenetheridge karenetheridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Julian Julian merged commit 0245dcc into json-schema-org:master Oct 16, 2021
@olegshtch olegshtch deleted the add-recursive-ref-test-suite branch October 17, 2021 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karenetheridge karenetheridge karenetheridge approved these changes

@jdesrosiers jdesrosiers jdesrosiers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@olegshtch @jdesrosiers @Julian @karenetheridge