Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add optional tests for $refing into known non-applicator keywords #697

Merged
merged 2 commits into from
Oct 27, 2023

Conversation

gregsdennis
Copy link
Member

Relates to json-everything/json-everything#537

I've put these in the optional tests as we already have some "reference into weird places" tests here.

@gregsdennis
Copy link
Member Author

Oh! Just realized I forgot the other drafts. I'll add those once the idea is confirmed good.

Copy link
Member

@karenetheridge karenetheridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@gregsdennis
Copy link
Member Author

I've updated the PR to include the tests in 2020-12 and 2019-09. It doesn't look like the "ref in weird places" tests exist in 7 or earlier, so I'm not adding them there.

Copy link
Member

@jdesrosiers jdesrosiers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works in my implementation.

@gregsdennis gregsdennis merged commit 9c88a0b into main Oct 27, 2023
3 checks passed
@gregsdennis gregsdennis deleted the gregsdennis/add-ref-into-known-nonapplicator branch October 27, 2023 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants