Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds int64 optional format test #711

Closed
wants to merge 2 commits into from

Conversation

spacether
Copy link
Contributor

@spacether spacether commented Dec 29, 2023

Adds int64 optional format test, an openapi numeric format

@spacether spacether requested a review from a team as a code owner December 29, 2023 17:29
@Julian
Copy link
Member

Julian commented Dec 29, 2023

Cool! Though sorry if I was unclear in the slack message -- by "help bootstrap" what I meant was -- I do think we should have these kinds of tests because they're useful to implementers of JSON Schema tooling, but I'm not convinced we should have them here precisely in this repo. I think we should have them in a parallel one which would have as its scope "all the formats in the OpenAPI format repository".

But yeah, I'm hesitant to add anything to this repository that isn't really part of JSON Schema "the specification itself".

I'm happy to create a parallel repository in the org we could use for that purpose -- and/or we can see whether others have opinions, but it doesn't feel totally right to have these here at first glance.

@spacether
Copy link
Contributor Author

spacether commented Dec 29, 2023

Reading the json schema spec, it allows custom formats and these custom formats have been in the openapi spec and the wild for years. Why not allow it here as an optional custom format?

@Julian
Copy link
Member

Julian commented Dec 29, 2023

Because doing so can easily be confused with "officially endorsing" a particular version or set of formats, and there isn't such endorsement from the JSON Schema spec or team. If there were, it'd be much easier to consider including them here.

There's already enough confusion about what the various files in the optional directory mean (see e.g. #590 which is trying to fix that)

@spacether
Copy link
Contributor Author

spacether commented Dec 29, 2023

Understood; another repo it is. Not sure where that repo should live though.
Maybe in https://github.com/OAI?
@MikeRalphson @earth2marsh @whitlockjc @webron @handrews what do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants