Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃悰 Bug: Warning in the terminal #448

Closed
JeelRajodiya opened this issue Mar 5, 2024 · 2 comments 路 Fixed by #465
Closed

馃悰 Bug: Warning in the terminal #448

JeelRajodiya opened this issue Mar 5, 2024 · 2 comments 路 Fixed by #465
Assignees
@JeelRajodiya
Labels
馃悰 Bug Indicates that the issue is a bug or defect. Status: In Progress This issue is being worked on, and has someone assigned.

Comments

@JeelRajodiya
Copy link
Contributor

JeelRajodiya commented Mar 5, 2024 •
edited
Loading

Describe the bug

A warning related to JsonEditor component appears in the terminal

Steps To Reproduce

How to reproduce? run the project locally and go to this url ( directly by entering this in addresser bar to ensure the page is rendered on the server).

You will see this warning in your terminal along with other hydration errors ( this error does not appear in the browser console it only appears in the terminal ).

image

Solution: You can find it here

Expected Behavior

There should be no warnings

Device Information [optional]

- OS: Win 11
- Browser: Chrome 
- version: 122.0.6261.95 (Official Build) (64-bit)

Are you working on this issue?

Yes

Do you think this work might require an [Architectural Decision Record (ADR)]? (significant or noteworthy)

No
@JeelRajodiya JeelRajodiya added Status: Triage This is the initial status for an issue that requires triage. 馃悰 Bug Indicates that the issue is a bug or defect. labels Mar 5, 2024
@Adity20
Copy link
Contributor

Adity20 commented Mar 5, 2024

Can I work on this @benjagm

@benjagm benjagm added Status: Available No one has claimed responsibility for resolving this issue. and removed Status: Triage This is the initial status for an issue that requires triage. labels Mar 5, 2024
@benjagm
Copy link
Collaborator

benjagm commented Mar 5, 2024

@JeelRajodiya I'll assign this to you considering you are already working on it.

@benjagm benjagm added Status: In Progress This issue is being worked on, and has someone assigned. and removed Status: Available No one has claimed responsibility for resolving this issue. labels Mar 5, 2024
JeelRajodiya added a commit to JeelRajodiya/JSON-Schema-website that referenced this issue Mar 6, 2024
@JeelRajodiya
Fix SSR issue with React.useLayoutEffect in
6b72abf 
JsonEditor

Resolves json-schema-org#448
@JeelRajodiya JeelRajodiya mentioned this issue Mar 6, 2024
Merged
benjagm pushed a commit that referenced this issue Mar 6, 2024
@JeelRajodiya
Fix SSR issue with React.useLayoutEffect in JsonEditor (#465)
e56d3a3 
* Fix SSR issue with React.useLayoutEffect in
JsonEditor

Resolves #448

* Update comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JeelRajodiya JeelRajodiya

Labels
馃悰 Bug Indicates that the issue is a bug or defect. Status: In Progress This issue is being worked on, and has someone assigned.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix SSR issue with React.useLayoutEffect in JsonEditor JeelRajodiya/JSON-Schema-website
3 participants
@benjagm @JeelRajodiya @Adity20