Feat: Add the Newsletter feature to the website. #489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@DhairyaMajmudar not able to do that i am getting this After linting it.
|
|
If you are using node version > 20 degrade it using with the help of node version manager , and then retry. |
|
@DhairyaMajmudar @benjagm done please check. |
|
Thanks a lot for moving this pr to the new branch! Found 2 small things: 1 We lost this change to add the form to the landing page: 2 After the changes added to the footer we'll need to reduce the vertical padding to make sure we show the footer. |
|
Awesome job here !!! I pushed some changes to make sure it merges well into the dev branch!! Excellent! |
benjagm
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue: #243
Summary:
Do you think resolving this issue might require an Architectural Decision Record (ADR)? (significant or noteworthy)
No
No