Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat]: Add Community Page #493

Closed
wants to merge 6 commits into from
Closed

[Feat]: Add Community Page #493

wants to merge 6 commits into from

Conversation

officeneerajsaini
Copy link
Contributor

I make a new saprate community page

What kind of change does this PR introduce?
Feature

Issue Number:

@officeneerajsaini
Copy link
Contributor Author

@benjagm done ✅

Copy link
Collaborator

@benjagm benjagm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing job here!! CONGRATS!!

Just some comments:

  • Can you change the color and font size of the card titles to be our corporative blue instead of purple?
  • JSON Schema Community title: Can you make the fonts bigger?
  • Events list: We have a lot of space to improve it. Can you build a better display for that section? See an idea here: https://dribbble.com/shots/16742982-Events-List-UI-Design
  • Blogs: This card needs some work. At the left side there should be a title, description and button like you did in ambassadors. At the right side we need to put what you actually have at the left side, the last published article.

We are almost there!!

@officeneerajsaini
Copy link
Contributor Author

I'm happy because you like my work. But first, I need to confirm something. As you mentioned before, 'Create a new page for Community inside the Overview Section of the Docs.' However, I added this in the navbar section of the community. I think that's a great place for it. What do you think? Where do we need to add this page?

@benjagm
Copy link
Collaborator

benjagm commented Mar 12, 2024

I'm happy because you like my work. But first, I need to confirm something. As you mentioned before, 'Create a new page for Community inside the Overview Section of the Docs.' However, I added this in the navbar section of the community. I think that's a great place for it. What do you think? Where do we need to add this page?

I like what you did. Great job. Thanks for thinking out of the box.

@officeneerajsaini officeneerajsaini requested a review from a team as a code owner March 20, 2024 09:36
@benjagm
Copy link
Collaborator

benjagm commented Mar 21, 2024

Hi @officeneerajsaini . Did you check my last comment? #493 (review)

@benjagm
Copy link
Collaborator

benjagm commented Mar 21, 2024

In addition. You did an amazing job with the orbits moving with users avatars, however I think this is a direct copy of what AsyncAPI did. They did it so cool se better to keep the privilege for them. Let's do something different still showing some avatars. I leave here a good example:

https://docs.astro.build/en/getting-started/

@officeneerajsaini
Copy link
Contributor Author

Yes, I copied from AsyncAPI, but now I will create something different.

@benjagm benjagm added the Status: In Progress This issue is being worked on, and has someone assigned. label Mar 22, 2024
@VivekJaiswal18
Copy link
Contributor

@benjagm if you approve can I also pitch a design for the community page.

@officeneerajsaini officeneerajsaini closed this by deleting the head repository Apr 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: In Progress This issue is being worked on, and has someone assigned.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants