Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added resource section #509

Merged
merged 12 commits into from
Mar 20, 2024

Conversation

Akshaybagai52
Copy link
Contributor

@Akshaybagai52 Akshaybagai52 commented Mar 11, 2024

What kind of change does this PR introduce?

Issue Number:

Screenshots/videos:

If relevant, did you update the documentation?

Summary

Does this PR introduce a breaking change?

@Akshaybagai52 Akshaybagai52 requested a review from a team as a code owner March 11, 2024 17:26
@benjagm
Copy link
Collaborator

benjagm commented Mar 11, 2024

What is the linked issue to this PR?

@Akshaybagai52 Akshaybagai52 changed the base branch from main to web-release-3 March 11, 2024 17:31
@Akshaybagai52
Copy link
Contributor Author

What is the linked issue to this PR?

#282

@gregsdennis
Copy link
Member

@Akshaybagai52 please update the opening comment. The issue links you have are formatted oddly. Just use the PR number, e.g. #282

@benjagm
Copy link
Collaborator

benjagm commented Mar 11, 2024

There is still a lot of changes that are not required. Did you do a rebase?

Copy link
Collaborator

@benjagm benjagm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking really promising. KUDOS for the hard work!!

You'll need to remove from this PR all the files unrelated to this feature. Have you rebased?

In addition:

  • I'll suggest reduce the space between every item of the list.
  • Change the icon for the sidebar section of resources. Maybe something like this: https://icons.getbootstrap.com/icons/bookshelf/
  • There is a strange effect when navigating that will require some attention. I'll record a video. This is the video.

pages/resources/[slug].page.tsx Show resolved Hide resolved
@benjagm
Copy link
Collaborator

benjagm commented Mar 11, 2024

The promised video with the strange behaviour when navigating between different resources and different sections of the sidebar.

HAWESOME JOB!!! We are really close!

video1985957256.mp4

@Akshaybagai52 Akshaybagai52 changed the title Feat/res feat: added resource section Mar 12, 2024
@Akshaybagai52
Copy link
Contributor Author

There is still a lot of changes that are not required. Did you do a rebase?

These changes are automatically coming whenever i'm changing base repo

@DhairyaMajmudar
Copy link
Member

I think its because you haven't synced the branch with the current branch.

@Akshaybagai52
Copy link
Contributor Author

I think its because you haven't synced the branch with the current branch.

Yeah I think I need to rebase the branch

@benjagm
Copy link
Collaborator

benjagm commented Mar 13, 2024

Thanks @Akshaybagai52 Please let me know when you need me to check this again.

@Akshaybagai52
Copy link
Contributor Author

Thanks @Akshaybagai52 Please let me know when you need me to check this again.

It is completed you can review now

@Akshaybagai52
Copy link
Contributor Author

Hello @benjagm did you review this PR ?

Copy link
Collaborator

@benjagm benjagm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing job here!! I pushed some changes to make sure it merges smoothly into the dev branch! Excellent Job!!

@benjagm benjagm merged commit 023a3c0 into json-schema-org:web-release-3 Mar 20, 2024
2 checks passed
@Akshaybagai52
Copy link
Contributor Author

Amazing job here!! I pushed some changes to make sure it merges smoothly into the dev branch! Excellent Job!!

Thankyou ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants