-
-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added resource section #509
feat: added resource section #509
Conversation
What is the linked issue to this PR? |
|
@Akshaybagai52 please update the opening comment. The issue links you have are formatted oddly. Just use the PR number, e.g. |
There is still a lot of changes that are not required. Did you do a rebase? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking really promising. KUDOS for the hard work!!
You'll need to remove from this PR all the files unrelated to this feature. Have you rebased?
In addition:
- I'll suggest reduce the space between every item of the list.
- Change the icon for the sidebar section of resources. Maybe something like this: https://icons.getbootstrap.com/icons/bookshelf/
- There is a strange effect when navigating that will require some attention. I'll record a video. This is the video.
The promised video with the strange behaviour when navigating between different resources and different sections of the sidebar. HAWESOME JOB!!! We are really close! video1985957256.mp4 |
These changes are automatically coming whenever i'm changing base repo |
I think its because you haven't synced the branch with the current branch. |
Yeah I think I need to rebase the branch |
Thanks @Akshaybagai52 Please let me know when you need me to check this again. |
It is completed you can review now |
Hello @benjagm did you review this PR ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing job here!! I pushed some changes to make sure it merges smoothly into the dev branch! Excellent Job!!
Thankyou ✨ |
What kind of change does this PR introduce?
Issue Number:
Screenshots/videos:
If relevant, did you update the documentation?
Summary
Does this PR introduce a breaking change?