-
-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: spacing between buttons #575
fix: spacing between buttons #575
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job. What you did works perfectly.
I just found un scenario where the all the buttons (search, theme and menu) are not in the best position because the right padding seems too much. The right padding of the menu icon should be the same than top and bottom. See image.
I know this was not part of the issue but it is a great opportunity to fix it.
I've fixed that can you check now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks for this!
What kind of change does this PR introduce?
Issue Number:
Screenshots/videos:
If relevant, did you update the documentation?
Summary
Does this PR introduce a breaking change?