Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: spacing between buttons #575

Merged
merged 11 commits into from
Apr 8, 2024

Conversation

Akshaybagai52
Copy link
Contributor

What kind of change does this PR introduce?

Issue Number:

Screenshots/videos:

If relevant, did you update the documentation?

Summary

Does this PR introduce a breaking change?

Copy link
Member

@DhairyaMajmudar DhairyaMajmudar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Copy link
Collaborator

@benjagm benjagm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job. What you did works perfectly.

I just found un scenario where the all the buttons (search, theme and menu) are not in the best position because the right padding seems too much. The right padding of the menu icon should be the same than top and bottom. See image.

Screenshot 2024-03-22 at 14 08 16

I know this was not part of the issue but it is a great opportunity to fix it.

@Akshaybagai52
Copy link
Contributor Author

Nice job. What you did works perfectly.

I just found un scenario where the all the buttons (search, theme and menu) are not in the best position because the right padding seems too much. The right padding of the menu icon should be the same than top and bottom. See image.

Screenshot 2024-03-22 at 14 08 16

I know this was not part of the issue but it is a great opportunity to fix it.

I've fixed that can you check now

@Akshaybagai52 Akshaybagai52 changed the title Fix/spacing fix: spacing between buttons Mar 24, 2024
@benjagm
Copy link
Collaborator

benjagm commented Mar 24, 2024

Thanks. That worked! However I found another scenario for Galaxy Fold (280x653):

Screenshot 2024-03-24 at 10 43 02

@Akshaybagai52
Copy link
Contributor Author

Thanks. That worked! However I found another scenario for Galaxy Fold (280x653):

Screenshot 2024-03-24 at 10 43 02

I've fix that can you review now
Thanks

Copy link
Collaborator

@benjagm benjagm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for this!

@benjagm benjagm merged commit f45b548 into json-schema-org:web-release-3 Apr 8, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants