Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Use-cases page #589

Merged

Conversation

VivekJaiswal18
Copy link
Contributor

What kind of change does this PR introduce?
Feature added
Added use cases page and modified card component with option to support multiple text sizes.

Issue Number:

Screenshots/videos:
image

If relevant, did you update the documentation?
NO

Does this PR introduce a breaking change?

NO

@VivekJaiswal18
Copy link
Contributor Author

@benjagm Please have a look
Thank you

Copy link
Member

@DhairyaMajmudar DhairyaMajmudar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Vivek you PR is looking good just left few suggestion to improve its compatibility for dark-theme and different screen sizes.

small: 'text-[0.85rem]',
medium: 'text-[1rem]',
large: 'text-[1.5rem]',
};
return (
<div className='group relative h-full w-full max-w-lg rounded-lg border border-gray-200 bg-white p-6 px-12 shadow-3xl transition-colors delay-[150ms] ease-in-out hover:bg-slate-100'>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here you can add the class dark:text-black to make the text inside cards dark-theme compatible

@DhairyaMajmudar
Copy link
Member

DhairyaMajmudar commented Mar 24, 2024

In dark mode text inside the cards is not visible which can be solved with the help of this solution #589 (comment)

image

@DhairyaMajmudar
Copy link
Member

  1. At screen size 820px one card is breaking you can look that in below figure.

image

  1. At screen size 768px the 2xn grid is breaking into 1xn grid you can check that in below image.

image

@VivekJaiswal18
Copy link
Contributor Author

VivekJaiswal18 commented Mar 24, 2024

Yes noticed that, and every other page using this card component is facing the same issues.
I think maybe the card component needs more work to be done with its responsiveness.

card.mp4

@VivekJaiswal18
Copy link
Contributor Author

@benjagm as the card component is giving some issues regarding the responsiveness and dark mode shall I correct it in this same PR so that the issue in every page using this component would get solved.

@benjagm
Copy link
Collaborator

benjagm commented Apr 1, 2024

shall I correct it in this same PR

Yes please! Thanks a lot!

Copy link
Collaborator

@benjagm benjagm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is ready to merge. Thanks a lot!!

Amazing job!

@benjagm benjagm merged commit 3647457 into json-schema-org:web-release-3 Apr 8, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants