-
-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Use-cases page #589
Added Use-cases page #589
Conversation
@benjagm Please have a look |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Vivek you PR is looking good just left few suggestion to improve its compatibility for dark-theme and different screen sizes.
small: 'text-[0.85rem]', | ||
medium: 'text-[1rem]', | ||
large: 'text-[1.5rem]', | ||
}; | ||
return ( | ||
<div className='group relative h-full w-full max-w-lg rounded-lg border border-gray-200 bg-white p-6 px-12 shadow-3xl transition-colors delay-[150ms] ease-in-out hover:bg-slate-100'> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here you can add the class dark:text-black
to make the text inside cards dark-theme compatible
In dark mode text inside the cards is not visible which can be solved with the help of this solution #589 (comment) |
Yes noticed that, and every other page using this card component is facing the same issues. card.mp4 |
@benjagm as the card component is giving some issues regarding the responsiveness and dark mode shall I correct it in this same PR so that the issue in every page using this component would get solved. |
Yes please! Thanks a lot! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is ready to merge. Thanks a lot!!
Amazing job!
What kind of change does this PR introduce?
Feature added
Added use cases page and modified card component with option to support multiple text sizes.
Issue Number:
Screenshots/videos:
![image](https://private-user-images.githubusercontent.com/96608169/316249093-05dfff7c-2595-4f64-8ae2-a808f90657db.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTg4ODExMjAsIm5iZiI6MTcxODg4MDgyMCwicGF0aCI6Ii85NjYwODE2OS8zMTYyNDkwOTMtMDVkZmZmN2MtMjU5NS00ZjY0LThhZTItYTgwOGY5MDY1N2RiLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA2MjAlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNjIwVDEwNTM0MFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTljOTczOTk4MWM4OTBhOThjMmVkNjBjNjAwYmMzMDVjZDQ0MzAzYTllMDk2MjViNmZiMzc1ZWEwNWZkMTAxZTEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.EQnMJKG5PugwBJuqjB73fpjyJyagbiHP-oCTwyokJQY)
If relevant, did you update the documentation?
NO
Does this PR introduce a breaking change?
NO