[Feat]: Add Community Page #493 #633
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix: remove unnecessary lines 'A snippet of the British royal family tree' seems to be a line that has been copied twice here but is irrelevant here. * fix: remove remnant line breaks removed the remnants of line breaks left by previous commit
* sidebar borders fix * dark theme sidebar border fix * border fix
…th (#568) * fix mobile navbar css * add resize event listener on the sidebar
* Add VPS Server as bronze sponsor * change url of sponsors
* Copyright Added in the Footer Section. * Inverted the order of the table. Columns Changes in the order as mention in issue.#572 * Some changes to improve solution * undo changes * . --------- Co-authored-by: Benjamin Granados <benjamin.granadosm@gmail.com>
…properly. (#611) * Add smooth scrolling and scroll padding to HTML * downgrade github-script version
* Adding hover effect * Resolving conflicts
* added gold, silver and bronze section in sponsors page * Differentiated sponsors in gold, silver and bronze and added button for "Add your logo" * Made some changes to improve the button style --------- Co-authored-by: Benjamin Granados <benjamin.granadosm@gmail.com>
* fix navbar close when click anywhere on screen * removed unnecessary file * Made requested change * Rename handleClickOutside function to handleCloseNavbar
Add redirect from tools to implementations
* resolved all invisible table headers * Fix css warnings --------- Co-authored-by: Benjamin Granados <benjamin.granadosm@gmail.com>
benjagm
requested changes
Apr 8, 2024
There was a problem hiding this comment.
After seeing the lot of unnecessary changes coming IT think will be better to create a fork from web-release-3 and manually add the community folder inside pages
otherwise merging this will be a nightmare.
In addition, I saw you adding multiple jsx files inside community which I think is not ideal for 2 reasons:
-
Let's use typescript instead javascript
-
Why breaking down into components that are not reusable at all? If those components are flexible and reusable maybe they can go into components but I seems that they are not reusable at all so better to avoid that breakdown of pieces to put all the logic inside /community/index.page.tsx
* fix * fix * fix This reverts commit 720a50b. * ten-three * Added hover effect to buttons * fix * yarn fix * rebased, fixed * search bbutton * Fix to center the search button content --------- Co-authored-by: Benjamin Granados <benjamin.granadosm@gmail.com>
* Update index.page.tsx * Update index.page.tsx with additional changes * Update index.page.tsx to resolve conflicts * resolving conflicts
* Added #website and slack link to feedback * changed the message to be more humble * improved sentence * Removed the svg and updated the message * fix
* Added padding and centered the buttons * Update index.page.tsx --------- Co-authored-by: Benjamin Granados <benjamin.granadosm@gmail.com>
* adding highlight * making dark mode compatible * making usestate boolean
* Update DarkModeToggle.tsx for implementation of dark mode in search popup * Update Layout.tsx for implementation of dark mode in search popup * some style fixing of keys in search popup * some style fixing on keys of search popup * linting fix * linting fixed * linting fix * linting fixed * linting fix * linting fixed * linting fix * linting fixed * linting fixed * Update Layout.tsx * Update DarkModeToggle.tsx * removed duplicate code * Updated Layout.tsx * added styles as classes in global.css
* fix * fix * fix This reverts commit 720a50b. * fix * lint ok * ignore yarn.lock * yarn correction * fix * yarnlock deletion * Solved merge conflicts : Sidenav bar closes dynamically * yarn fix * rebased to latest version * fix * unwanted space * unwanted changes * unwanted issue * unwated issue * Update globals.css
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I make a new separate community page
What kind of change does this PR introduce?
Feature
Issue Number: