Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Replacing Axios to fs fetching in resources page #657

Merged
merged 3 commits into from
Apr 23, 2024
Merged

Feat: Replacing Axios to fs fetching in resources page #657

merged 3 commits into from
Apr 23, 2024

Conversation

DhairyaMajmudar
Copy link
Member

What kind of change does this PR introduce?

  1. Removed items of type Adoption, Article, Tutorial and Vocabulary
  2. Replaced Axios fetch to fs fetch while fetching data from data/resources.yml file

Issue Number:

Summary
Removed suggested types and replaced axios with fs module

benjagm
benjagm approved these changes Apr 23, 2024
View reviewed changes
Copy link
Collaborator

@benjagm benjagm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works. Thanks Dhairya!

@benjagm benjagm merged commit c04d577 into json-schema-org:web-release-3 Apr 23, 2024
2 checks passed
@DhairyaMajmudar DhairyaMajmudar deleted the resource branch April 23, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjagm benjagm benjagm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@DhairyaMajmudar @benjagm