Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update index.page.tsx #684

Merged
merged 7 commits into from
May 23, 2024
Merged

Conversation

kwennB
Copy link

@kwennB kwennB commented Apr 30, 2024

What kind of change does this PR introduce?
Enhancement to documentation

Issue Number:
Closes #660

Summary
Removed the placeholders texts for the newly created welcome page in the release 3.
json-schema-org#660

Does this PR introduce a breaking change?
No

Edited the placeholder texts for the welcome page.
Copy link
Member

@DhairyaMajmudar DhairyaMajmudar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, @kwennB can you pls. once have a look at that failing lint check.

Thank You : )

Copy link
Collaborator

@benjagm benjagm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @kwennB . Nice job!

As discussed please adjust the tone to better fit our personas.

@kwennB kwennB requested a review from a team as a code owner May 21, 2024 11:55
Copy link
Collaborator

@benjagm benjagm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just left small suggestions before getting this merged.

pages/overview/welcome/index.page.tsx Outdated Show resolved Hide resolved
pages/overview/welcome/index.page.tsx Outdated Show resolved Hide resolved
kwennB and others added 2 commits May 23, 2024 13:14
Co-authored-by: Benjamin Granados <40007659+benjagm@users.noreply.github.com>
Co-authored-by: Benjamin Granados <40007659+benjagm@users.noreply.github.com>
Copy link
Collaborator

@benjagm benjagm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job Blessing!

@benjagm benjagm merged commit d8ef58c into json-schema-org:web-release-3 May 23, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants