-
-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update index.page.tsx #684
Conversation
Edited the placeholder texts for the welcome page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello, @kwennB can you pls. once have a look at that failing lint check.
Thank You : )
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @kwennB . Nice job!
As discussed please adjust the tone to better fit our personas.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just left small suggestions before getting this merged.
Co-authored-by: Benjamin Granados <40007659+benjagm@users.noreply.github.com>
Co-authored-by: Benjamin Granados <40007659+benjagm@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job Blessing!
What kind of change does this PR introduce?
Enhancement to documentation
Issue Number:
Closes #660
Summary
Removed the placeholders texts for the newly created welcome page in the release 3.
json-schema-org#660
Does this PR introduce a breaking change?
No