Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Rebuilding getting started component #687

Merged
merged 26 commits into from
Jun 24, 2024
Merged

Feat: Rebuilding getting started component #687

merged 26 commits into from
Jun 24, 2024

Conversation

DhairyaMajmudar
Copy link
Member

@DhairyaMajmudar DhairyaMajmudar commented May 10, 2024 •
edited by benjagm
Loading

What kind of change does this PR introduce?

Rebuilding getting started guide

Issue Number:

Screenshots/videos:
N/A

If relevant, did you update the documentation?
N/A

Summary
Getting stated guide added.

Does this PR introduce a breaking change?
No

@DhairyaMajmudar DhairyaMajmudar requested a review from a team as a code owner May 10, 2024 14:41
@DhairyaMajmudar DhairyaMajmudar marked this pull request as draft May 23, 2024 13:24
@DhairyaMajmudar DhairyaMajmudar changed the title Feat: Rebuilding getting started guide Feat: Rebuilding getting started component May 29, 2024
@DhairyaMajmudar DhairyaMajmudar added the GSoD Google Season of Docs label May 29, 2024
@DhairyaMajmudar DhairyaMajmudar marked this pull request as ready for review May 29, 2024 13:29
@DhairyaMajmudar DhairyaMajmudar changed the title Feat: Rebuilding getting started component [WIP] Feat: Rebuilding getting started component May 29, 2024
@DhairyaMajmudar DhairyaMajmudar marked this pull request as draft May 29, 2024 14:52
@DhairyaMajmudar DhairyaMajmudar marked this pull request as ready for review June 17, 2024 15:09
benjagm
benjagm requested changes Jun 17, 2024
View reviewed changes
Copy link
Collaborator

@benjagm benjagm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is very very close! Congrats!

Left some suggestions to change texts and also found that the default instance is not loading properly.

pages/learn/getting-started-step-by-step/index.page.tsx Outdated Show resolved Hide resolved
pages/learn/getting-started-step-by-step/index.page.tsx Outdated Show resolved Hide resolved
data/getting-started-examples.json Outdated Show resolved Hide resolved
benjagm
benjagm requested changes Jun 20, 2024
View reviewed changes
Copy link
Collaborator

@benjagm benjagm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment regarding the GettingStarted component. There is some hardcoded logic that is not supposed to be there.

components/GettingStarted.tsx Outdated Show resolved Hide resolved
@DhairyaMajmudar DhairyaMajmudar changed the title [WIP] Feat: Rebuilding getting started component Feat: Rebuilding getting started component Jun 22, 2024
benjagm
benjagm approved these changes Jun 24, 2024
View reviewed changes
Copy link
Collaborator

@benjagm benjagm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me. I added the last changes and now I am asking for some more reviews.

@benjagm benjagm changed the base branch from main to web-new-getting-started June 24, 2024 22:27
@benjagm benjagm merged commit 6b7e5e7 into json-schema-org:web-new-getting-started Jun 24, 2024
6 checks passed
@benjagm benjagm removed the request for review from Relequestual June 24, 2024 22:29
@DhairyaMajmudar DhairyaMajmudar deleted the started branch June 28, 2024 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjagm benjagm benjagm approved these changes

Assignees

@DhairyaMajmudar DhairyaMajmudar

Labels
GSoD Google Season of Docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

✨ Enhancement: Rebuild the getting started guide
2 participants
@DhairyaMajmudar @benjagm