Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Removing resources and newletter from web-release-3 branch #698

Merged
merged 5 commits into from
May 23, 2024

Conversation

DhairyaMajmudar
Copy link
Member

@DhairyaMajmudar DhairyaMajmudar commented May 20, 2024

GSoD'24 | web-release-3

Issue Number:

Related to #158

Screenshots/videos:
N/A

If relevant, did you update the documentation?
N/A

Summary
Removal of newsletter and resources from web-release-3 branch

Does this PR introduce a breaking change?
N/A

@DhairyaMajmudar DhairyaMajmudar marked this pull request as draft May 20, 2024 13:48
@DhairyaMajmudar DhairyaMajmudar changed the title Feat: Remvoing resources and newletter from web-release-3 branch Feat: Removing resources and newletter from web-release-3 branch May 20, 2024
@DhairyaMajmudar DhairyaMajmudar added the GSoD Google Season of Docs label May 20, 2024
@DhairyaMajmudar DhairyaMajmudar marked this pull request as ready for review May 20, 2024 14:43
Copy link
Collaborator

@benjagm benjagm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Dhairya! The only pending action is remove the Resources item from the new Welcome page of the docs:

/pages/overview/welcome/index.page.tsx

@DhairyaMajmudar DhairyaMajmudar requested a review from a team as a code owner May 21, 2024 12:58
@DhairyaMajmudar
Copy link
Member Author

Thanks Dhairya! The only pending action is remove the Resources item from the new Welcome page of the docs:

/pages/overview/welcome/index.page.tsx

Done the changes : )

@benjagm benjagm merged commit 3991da0 into json-schema-org:web-release-3 May 23, 2024
1 check passed
@DhairyaMajmudar DhairyaMajmudar deleted the web-r-3-rem branch May 23, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GSoD Google Season of Docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants