You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
ATM the 'to box or not to box' is too simplistic. We need to know if there is a cycle at play, and if so, always box. The cycles can exist in subschema branches, and so the simplistic approach isnt working for json-schema meta schema.
There are multiple approaches with varying complexity to implement.
Box everything
Box all refs to struct or enums. Still requires checking the inside of things instead of just pulling the title from the ref, but only 1 level deep still.
Hook into traverse method as its running, passing along the isCycle param. Codegen methods can then handle boxing themselves if they are part of a cycle.
while doing initial processing, create a map that holds schema.title -> is a cycle. Use this map later to decide if you should box or not.
The text was updated successfully, but these errors were encountered:
ATM the 'to box or not to box' is too simplistic. We need to know if there is a cycle at play, and if so, always box. The cycles can exist in subschema branches, and so the simplistic approach isnt working for json-schema meta schema.
There are multiple approaches with varying complexity to implement.
isCycle
param. Codegen methods can then handle boxing themselves if they are part of a cycle.The text was updated successfully, but these errors were encountered: