Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#11: Format snapshots using LF only regardless of platform #12

Merged
merged 1 commit into from
Feb 12, 2019

Conversation

grimsa
Copy link
Collaborator

@grimsa grimsa commented Feb 5, 2019

Addresses #11

@metas-ts
Copy link
Contributor

I did the following, all in a cmd.exe shell on windows 10

git clone https://github.com/grimsa/json-snapshot.github.io.git
cd json-snapshot.github.io
git checkout bugfix/11

Then i edited the pom.xml and

  • renamed the artifact from json-snapshot to json-snapshot-PR
  • commented out the last 3 plugins, i.e.
    • maven-gpg-plugin
    • maven-deploy-plugin
    • nexus-staging-maven-plugin

Then I did

mvn clean install

with mvn 3.6.0

The build succeeded and installed json-snapshot-PR-1.0.15.jar into my local repo.
I then retried the tests whose failing lead me to this issue in the first place and revified that also these tests now succeed (if the -PR artifact).

Note that building the master branch failed, as expected.

I hope this helps with the review, so this fix can be integrated quickly.

PS: for the time being we are using the artifact that I just build, but obviously it would be great for us if it could be integrated soon.

@andrebonna andrebonna merged commit d34172f into json-snapshot:master Feb 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants