-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move CLI to its own package #205
Comments
Good point. But that means that users would need to globally install minimist to use the JSON5 CLI. I think a better option is to decouple the library from the CLI. |
Hi @jordanbtucker, thanks for this lib! Is there any news about this issue? json5 is widely used now, many tools must parse json5 config files, and this issue can be blocking in many situations. As it is a production dependency for projects, it should be autonomous. |
@cyrilletuzi Thanks for your interest. This is a breaking change, and I haven't had time to finalize a v3 for JSON5. Can you explain why the dependence on minimist is blocking? |
@jordanbtucker Thanks for your answer. If
|
@cyrilletuzi Thanks for bringing these valid concerns to my attention. I'll see if I can devote some time to a v3 release soon. |
It doesn't need to be a breaking change. By creating a new package: Everyone who wants to use the |
Okay |
Json5 module has a hard dependecy on minimist package which is necessary only when you run a CLI for converting JSON5 to JSON and for validating the syntax of JSON5 documents.
I sugest to change it to "optionalDependencies".
The text was updated successfully, but these errors were encountered: